From f7cb0322c2d7939398a064d2f31b63ed8902b1c6 Mon Sep 17 00:00:00 2001
From: ringabout <43030857+ringabout@users.noreply.github.com>
Date: Thu, 3 Oct 2024 00:25:59 +0800
Subject: improve error messages for illegalCapture (#24214)
ref https://forum.nim-lang.org/t/12536
Use a general recommendation to avoid some weird error messages like
`<ref ref var Test>` etc.
---
compiler/lambdalifting.nim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compiler/lambdalifting.nim b/compiler/lambdalifting.nim
index 2d38d9a69..54cdfc5bc 100644
--- a/compiler/lambdalifting.nim
+++ b/compiler/lambdalifting.nim
@@ -300,8 +300,8 @@ proc markAsClosure(g: ModuleGraph; owner: PSym; n: PNode) =
localError(g.config, n.info,
("'$1' is of type <$2> which cannot be captured as it would violate memory" &
" safety, declared here: $3; using '-d:nimNoLentIterators' helps in some cases." &
- " Consider using a <ref $2> which can be captured.") %
- [s.name.s, typeToString(s.typ), g.config$s.info])
+ " Consider using a <ref T> which can be captured.") %
+ [s.name.s, typeToString(s.typ.skipTypes({tyVar})), g.config$s.info])
elif not (owner.typ.isClosure or owner.isNimcall and not owner.isExplicitCallConv or isEnv):
localError(g.config, n.info, "illegal capture '$1' because '$2' has the calling convention: <$3>" %
[s.name.s, owner.name.s, $owner.typ.callConv])
--
cgit 1.4.1-2-gfad0
b1f0b1c175a8f56223232d9f52'>blame</a> <a href='/akkartik/teliva/commit/src/lualib.h?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>commit</a> <a href='/akkartik/teliva/diff/src/lualib.h?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>diff</a> <a href='/akkartik/teliva/stats/src/lualib.h'>stats</a></td><td class='form'><form class='right' method='get' action='/akkartik/teliva/log/src/lualib.h'>
<input type='hidden' name='id' value='0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/akkartik/teliva/blame/?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>root</a>/<a href='/akkartik/teliva/blame/src?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>src</a>/<a href='/akkartik/teliva/blame/src/lualib.h?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>lualib.h</a></div><div class='content'>blob: 02924dd01a1d1524553b0d340f81a44fb6a6cdd7 (<a href='/akkartik/teliva/plain/src/lualib.h?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>plain</a>) (<a href='/akkartik/teliva/tree/src/lualib.h?id=0d6378aa51f8dfb1f0b1c175a8f56223232d9f52'>tree</a>)
<table class='blame blob'>
<tr>
<td class='hashes'><div class='alt'><pre><span class='oid'><a title='author Kartik K. Agaram <vc@akkartik.com> 2021-10-19 21:38:48 -0700
committer Kartik K. Agaram <vc@akkartik.com> 2021-10-22 19:24:44 -0700
new fork of Lua 5.1' href='/akkartik/teliva/commit/src/lualib.h?id=74f8cd15bb43110973deffdeb9dd229797e5b328'>74f8cd1</a></span>
</pre></div><div class='alt'><pre><span class='oid'><a title='author Kartik K. Agaram <vc@akkartik.com> 2021-11-05 10:26:47 -0700
committer Kartik K. Agaram <vc@akkartik.com> 2021-11-05 10:30:07 -0700
starting on curses library' href='/akkartik/teliva/commit/src/lualib.h?id=8552ad4ced8ccd0cf5276bf6d03f0c43028be8af'>8552ad4</a></span> <a title='Blame the previous revision' href='/akkartik/teliva/blame/src/lualib.h?id=37b05c2957657ca618dfc183a909705b32b7adc5'>^</a>
</pre></div><div class='alt'><pre><span class='oid'><a title='author Kartik K. Agaram <vc@akkartik.com> 2021-10-19 21:38:48 -0700
committer Kartik K. Agaram <vc@akkartik.com> 2021-10-22 19:24:44 -0700
new fork of Lua 5.1' href='/akkartik/teliva/commit/src/lualib.h?id=74f8cd15bb43110973deffdeb9dd229797e5b328'>74f8cd1</a></span>
</pre></div></td>
<td class='linenumbers'><div class='alt'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
</pre></div><div class='alt'><pre><a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
</pre></div><div class='alt'><pre><a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
<a id='n51' href='#n51'>51</a>
<a id='n52' href='#n52'>52</a>
<a id='n53' href='#n53'>53</a>
<a id='n54' href='#n54'>54</a>
<a id='n55' href='#n55'>55</a>
<a id='n56' href='#n56'>56</a>
</pre></div></td>
<td class='lines'><div><div><div class='alt'><pre>
</pre></div><div class='alt'><pre>
</pre></div><div class='alt'><pre>
</pre></div></div><pre><code>