From 6b9a139f7f27422bc2d7dc3fad20d589518a93b5 Mon Sep 17 00:00:00 2001 From: Arne Döring Date: Tue, 19 Feb 2019 12:21:42 +0100 Subject: error message for accidental use of macro (#10490) * error message for accidental use of macro --- compiler/semstmts.nim | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'compiler') diff --git a/compiler/semstmts.nim b/compiler/semstmts.nim index cd570caad..3827da220 100644 --- a/compiler/semstmts.nim +++ b/compiler/semstmts.nim @@ -448,10 +448,14 @@ proc semVarOrLet(c: PContext, n: PNode, symkind: TSymKind): PNode = var def: PNode = c.graph.emptyNode if a.sons[length-1].kind != nkEmpty: def = semExprWithType(c, a.sons[length-1], {efAllowDestructor}) - if def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro: + if def.typ.kind == tyProc and def.kind == nkSym and def.sym.kind == skMacro: + localError(c.config, def.info, "cannot assign macro symbol to variable here. Forgot to invoke the macro with '()'?") + def.typ = errorType(c) + elif def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro: # prevent the all too common 'var x = int' bug: localError(c.config, def.info, "'typedesc' metatype is not valid here; typed '=' instead of ':'?") def.typ = errorType(c) + if typ != nil: if typ.isMetaType: def = inferWithMetatype(c, typ, def) @@ -583,7 +587,10 @@ proc semConst(c: PContext, n: PNode): PNode = localError(c.config, a.sons[length-1].info, errConstExprExpected) continue - if def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro: + if def.typ.kind == tyProc and def.kind == nkSym and def.sym.kind == skMacro: + localError(c.config, def.info, "cannot assign macro symbol to constant here. Forgot to invoke the macro with '()'?") + def.typ = errorType(c) + elif def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro: # prevent the all too common 'const x = int' bug: localError(c.config, def.info, "'typedesc' metatype is not valid here; typed '=' instead of ':'?") def.typ = errorType(c) -- cgit 1.4.1-2-gfad0