From 7d6cbf290a5e0cbce14b9926f57221a017f20a4a Mon Sep 17 00:00:00 2001 From: Jacek Sieka Date: Tue, 28 Apr 2020 19:56:01 +0200 Subject: Error -> Defect for defects (#13908) * Error -> Defect for defects The distinction between Error and Defect is subjective, context-dependent and somewhat arbitrary, so when looking at an exception, it's hard to guess what it is - this happens often when looking at a `raises` list _without_ opening the corresponding definition and digging through layers of inheritance. With the help of a little consistency in naming, it's at least possible to start disentangling the two error types and the standard lib can set a good example here. --- examples/tunit.nim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'examples') diff --git a/examples/tunit.nim b/examples/tunit.nim index bc447812d..e8ff8a952 100644 --- a/examples/tunit.nim +++ b/examples/tunit.nim @@ -29,7 +29,7 @@ proc foo: bool = return true proc err = - raise newException(ArithmeticError, "some exception") + raise newException(ArithmeticDefect, "some exception") test "final test": echo "inside suite-less test" @@ -40,8 +40,8 @@ test "final test": d > 10 test "arithmetic failure": - expect(ArithmeticError): + expect(ArithmeticDefect): err() - expect(ArithmeticError, CatchableError): + expect(ArithmeticDefect, CatchableError): discard foo() -- cgit 1.4.1-2-gfad0