From 5456da3ca9fe900954a393a707281952a168c8b6 Mon Sep 17 00:00:00 2001 From: Oscar NihlgÄrd Date: Fri, 29 Nov 2019 11:15:21 +0100 Subject: Fix sequtils.delete bug with out of bounds indexes (#12506) --- lib/pure/collections/sequtils.nim | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'lib/pure') diff --git a/lib/pure/collections/sequtils.nim b/lib/pure/collections/sequtils.nim index 0bf5f82d3..a20f0d0b7 100644 --- a/lib/pure/collections/sequtils.nim +++ b/lib/pure/collections/sequtils.nim @@ -447,7 +447,9 @@ proc delete*[T](s: var seq[T]; first, last: Natural) = var dest = @[1, 1, 1, 2, 2, 2, 2, 2, 2, 1, 1, 1, 1, 1] dest.delete(3, 8) assert outcome == dest - + doAssert first <= last + if first >= s.len: + return var i = first var j = min(len(s), last+1) var newLen = len(s)-j+i @@ -1173,6 +1175,9 @@ when isMainModule: assert outcome == dest, """\ Deleting range 3-9 from [1,1,1,2,2,2,2,2,2,1,1,1,1,1] is [1,1,1,1,1,1,1,1]""" + var x = @[1, 2, 3] + x.delete(100, 100) + assert x == @[1, 2, 3] block: # insert tests var dest = @[1, 1, 1, 1, 1, 1, 1, 1] -- cgit 1.4.1-2-gfad0