From 42e8472ca6eab740c0879428bd119ec94e70fe74 Mon Sep 17 00:00:00 2001 From: metagn Date: Wed, 5 Jun 2024 21:53:05 +0300 Subject: fix noreturn/implicit discard check logic (#23681) fixes #10440, fixes #13871, fixes #14665, fixes #19672, fixes #23677 The false positive in #23677 was caused by behavior in `implicitlyDiscardable` where only the last node of `if`/`case`/`try` etc expressions were considered, as in the final node of the final branch (in this case `else`). To fix this we use the same iteration in `implicitlyDiscardable` that we use in `endsInNoReturn`, with the difference that for an `if`/`case`/`try` statement to be implicitly discardable, all of its branches must be implicitly discardable. `noreturn` calls are also considered implicitly discardable for this reason, otherwise stuff like `if true: discardableCall() else: error()` doesn't compile. However `endsInNoReturn` also had bugs, one where `finally` was considered in noreturn checking when it shouldn't, another where only `nkIfStmt` was checked and not `nkIfExpr`, and the node given for the error message was bad. So `endsInNoReturn` now skips over `skipForDiscardable` which no longer contains `nkIfStmt`/`nkCaseStmt`/`nkTryStmt`, stores the first encountered returning node in a var parameter for the error message, and handles `finally` and `nkIfExpr`. Fixing #23677 already broke a line in `syncio` so some package code might be affected. --- lib/std/syncio.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/std') diff --git a/lib/std/syncio.nim b/lib/std/syncio.nim index 2b39375ea..c34a025af 100644 --- a/lib/std/syncio.nim +++ b/lib/std/syncio.nim @@ -874,7 +874,7 @@ proc writeFile*(filename: string, content: openArray[byte]) {.since: (1, 1).} = var f: File = nil if open(f, filename, fmWrite): try: - f.writeBuffer(unsafeAddr content[0], content.len) + discard f.writeBuffer(unsafeAddr content[0], content.len) finally: close(f) else: -- cgit 1.4.1-2-gfad0 elect name='qt'>
path: root/build/empty.txt
blob: 6661420738f2977b47b69cc6621bdfe34d01bf70 (plain) (blame) 
1

commit/readme.md?h=devel&id=759a586b19fbcb41639612a4d7ebc8c924a9a818'>759a586b1 ^

ac3cc140f ^

03b05bd34 ^



a16e6bd22 ^

1a7fdb09d ^












60d437427 ^


1a7fdb09d ^


d1cf04a38 ^

1a7fdb09d ^

a16e6bd22 ^

03b05bd34 ^


57dc4ca22 ^

a16e6bd22 ^


03b05bd34 ^

57dc4ca22 ^

03b05bd34 ^


a16e6bd22 ^

1a7fdb09d ^





03b05bd34 ^

a16e6bd22 ^

03b05bd34 ^

a16e6bd22 ^

03b05bd34 ^




9e170f115 ^

03b05bd34 ^

823b3c250 ^

03b05bd34 ^

506418ef5 ^

a16e6bd22 ^

86c65db18 ^

f97decaa2 ^



bc9749310 ^

506418ef5 ^

3c870d3bb ^


506418ef5 ^





3c870d3bb ^

506418ef5 ^

3c870d3bb ^

506418ef5 ^









a16e6bd22 ^


03b05bd34 ^


a16e6bd22 ^

03b05bd34 ^




a16e6bd22 ^

03b05bd34 ^

1a7fdb09d ^

03b05bd34 ^


49d810f34 ^

03b05bd34 ^


ae0e5604f ^

49d810f34 ^

46ee026e7 ^

f97decaa2 ^


342834d7f ^



6b38b37b4 ^

0fff332b8 ^

342834d7f ^

46ee026e7 ^

c8da41721 ^

03b05bd34 ^


510392bc6 ^

46ee026e7 ^

11a664dfb ^




46ee026e7 ^


03b05bd34 ^

3cef2129b ^


46ee026e7 ^


03b05bd34 ^

46ee026e7 ^

03b05bd34 ^


















da2fd42e6 ^

03b05bd34 ^








342834d7f ^

03b05bd34 ^





a16e6bd22 ^

342834d7f ^



6b38b37b4 ^

342834d7f ^



















6b38b37b4 ^

342834d7f ^

a16e6bd22 ^

03b05bd34 ^





1a7fdb09d ^

03b05bd34 ^

a55f49a7b ^

03b05bd34 ^











60d437427 ^

03b05bd34 ^











03b05bd34 ^


03b05bd34 ^

d1cf04a38 ^

1

2

3
4
5

6

7
8
9
10
11
12
13
14
15
16
17
18

19
20

21
22

23

24

25

26
27

28

29
30

31

32

33
34

35

36
37
38
39
40

41

42

43

44

45
46
47
48

49

50

51

52

53

54

55

56
57
58

59

60

61
62

63
64
65
66
67

68

69

70

71
72
73
74
75
76
77
78
79

80
81

82
83

84

85
86
87
88

89

90

91

92
93

94

95
96

97

98

99

100
101

102
103
104

105

106

107

108

109

110
111

112

113

114
115
116
117

118
119

120

121
122

123
124

125

126

127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144

145

146
147
148
149
150
151
152
153

154

155
156
157
158
159

160

161
162
163

164

165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183

184

185

186

187
188
189
190
191

192

193

194

195
196
197
198
199
200
201
202
203
204
205

206

207
208
209
210
211
212
213
214
215
216
217

218
219

220

221