From 7d6cbf290a5e0cbce14b9926f57221a017f20a4a Mon Sep 17 00:00:00 2001 From: Jacek Sieka Date: Tue, 28 Apr 2020 19:56:01 +0200 Subject: Error -> Defect for defects (#13908) * Error -> Defect for defects The distinction between Error and Defect is subjective, context-dependent and somewhat arbitrary, so when looking at an exception, it's hard to guess what it is - this happens often when looking at a `raises` list _without_ opening the corresponding definition and digging through layers of inheritance. With the help of a little consistency in naming, it's at least possible to start disentangling the two error types and the standard lib can set a good example here. --- lib/system/gc_ms.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/system/gc_ms.nim') diff --git a/lib/system/gc_ms.nim b/lib/system/gc_ms.nim index a3b163a67..eda220901 100644 --- a/lib/system/gc_ms.nim +++ b/lib/system/gc_ms.nim @@ -496,7 +496,7 @@ when not defined(useNimRtl): inc(gch.recGcLock) proc GC_enable() = if gch.recGcLock <= 0: - raise newException(AssertionError, + raise newException(AssertionDefect, "API usage error: GC_enable called but GC is already enabled") dec(gch.recGcLock) -- cgit 1.4.1-2-gfad0