From 1330597f6df1d2f7d23ec25a7705e21be2e78d29 Mon Sep 17 00:00:00 2001 From: Miran Date: Sat, 25 Jul 2020 09:53:47 +0200 Subject: deprecate tables.add (#15047) --- lib/pure/collections/tables.nim | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/pure/collections/tables.nim b/lib/pure/collections/tables.nim index cf864c640..a8742bdbe 100644 --- a/lib/pure/collections/tables.nim +++ b/lib/pure/collections/tables.nim @@ -484,7 +484,8 @@ proc len*[A, B](t: Table[A, B]): int = result = t.counter -proc add*[A, B](t: var Table[A, B], key: A, val: B) = +proc add*[A, B](t: var Table[A, B], key: A, val: B) {.deprecated: + "Deprecated since v1.4; it was more confusing than useful, use `[]=`".} = ## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists. ## ## **This can introduce duplicate keys into the table!** @@ -962,7 +963,8 @@ proc len*[A, B](t: TableRef[A, B]): int = result = t.counter -proc add*[A, B](t: TableRef[A, B], key: A, val: B) = +proc add*[A, B](t: TableRef[A, B], key: A, val: B) {.deprecated: + "Deprecated since v1.4; it was more confusing than useful, use `[]=`".} = ## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists. ## ## **This can introduce duplicate keys into the table!** @@ -1448,7 +1450,8 @@ proc len*[A, B](t: OrderedTable[A, B]): int {.inline.} = result = t.counter -proc add*[A, B](t: var OrderedTable[A, B], key: A, val: B) = +proc add*[A, B](t: var OrderedTable[A, B], key: A, val: B) {.deprecated: + "Deprecated since v1.4; it was more confusing than useful, use `[]=`".} = ## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists. ## ## **This can introduce duplicate keys into the table!** @@ -1935,7 +1938,8 @@ proc len*[A, B](t: OrderedTableRef[A, B]): int {.inline.} = result = t.counter -proc add*[A, B](t: OrderedTableRef[A, B], key: A, val: B) = +proc add*[A, B](t: OrderedTableRef[A, B], key: A, val: B) {.deprecated: + "Deprecated since v1.4; it was more confusing than useful, use `[]=`".} = ## Puts a new ``(key, value)`` pair into ``t`` even if ``t[key]`` already exists. ## ## **This can introduce duplicate keys into the table!** -- cgit 1.4.1-2-gfad0