From 080b0a03bd724ea50c5b90553c0aedc47be56a5e Mon Sep 17 00:00:00 2001 From: metagn Date: Wed, 4 Sep 2024 10:25:01 +0300 Subject: streams: implement readStr for VM, document VM limitations (#24058) fixes #24054 `readData` is not implemented for the VM as mentioned in the issue, but `readDataStr` is, so that is used for `readStr` instead on the VM. We could also just use it in general since it falls back to `readData` anyway but it's kept the same otherwise for now. Also where and why streams in general don't work in VM is now documented on the top level `streams` module documentation. --- testament/important_packages.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'testament') diff --git a/testament/important_packages.nim b/testament/important_packages.nim index 8ac28df10..efec04b3c 100644 --- a/testament/important_packages.nim +++ b/testament/important_packages.nim @@ -181,7 +181,7 @@ pkg "unicodeplus", "nim c -d:release -r tests/tests.nim" pkg "union", "nim c -r tests/treadme.nim", url = "https://github.com/alaviss/union" pkg "unittest2" pkg "unpack" -pkg "weave", "nimble install cligen@#HEAD; nimble test_gc_arc", useHead = true +pkg "weave", "nimble install -y cligen@#HEAD; nimble test_gc_arc", useHead = true pkg "websock" pkg "websocket", "nim c websocket.nim" # pkg "winim", allowFailure = true -- cgit 1.4.1-2-gfad0