From 560b0150bdb120590f6d581da5b7180bac6df52c Mon Sep 17 00:00:00 2001 From: bptato Date: Mon, 20 May 2024 18:31:39 +0200 Subject: buffer: never unlink controlling socket in cleanup The pager already unlinks it, so ideally this should change nothing. (This was causing buffer processes to core dump on OpenBSD, because I forgot that I removed unlink promise. Better keep code paths the same when possible...) --- src/server/buffer.nim | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/server/buffer.nim b/src/server/buffer.nim index 178dd94b..cffe33b1 100644 --- a/src/server/buffer.nim +++ b/src/server/buffer.nim @@ -1955,11 +1955,8 @@ proc runBuffer(buffer: Buffer) = proc cleanup(buffer: Buffer) = buffer.pstream.sclose() urandom.sclose() - # no unlink access on Linux - when defined(linux): - buffer.ssock.close(unlink = false) - else: - buffer.ssock.close() + # no unlink access on Linux, so just hope that the pager could clean it up + buffer.ssock.close(unlink = false) proc launchBuffer*(config: BufferConfig; url: URL; attrs: WindowAttributes; ishtml: bool; charsetStack: seq[Charset]; loader: FileLoader; -- cgit 1.4.1-2-gfad0