about summary refs log tree commit diff stats
path: root/linkify
diff options
context:
space:
mode:
authorKartik K. Agaram <vc@akkartik.com>2017-06-25 01:48:56 -0700
committerKartik K. Agaram <vc@akkartik.com>2017-06-25 01:48:56 -0700
commit5405a972e44259d65c374a3c9e583e026ad7cd8e (patch)
tree84842958f20e836c1c82163dcd7781785104051a /linkify
parentd5a492d384994af1c4840d51b3251f384af80e86 (diff)
downloadmu-5405a972e44259d65c374a3c9e583e026ad7cd8e.tar.gz
3954
As a blanket rule, down-arrow now stops scrolling once the bottom margin
comes on screen.

Now that we have page-wise scrolling with ctrl-f/b and line-wise
scrolling with ctrl-s/x, we don't need to conflate scroll positioning
with the arrow keys. And as a result, early students no longer have to
struggle with accidentally scrolling part of the sandbox off the screen
when there's tons of empty space available.

`move-to-next-line` is still super messy and will need further
rethinking, but this commit simplifies the codebase as a whole by
eliminating a couple of historical accidents:

  a) We only introduced scrolling past the bottom of the screen to allow
  more sandboxes to come into view before we had scrolling for the
  sandbox side.

  b) We undid scrolling past the bottom in just the recipe side to allow
  errors to come into view.

Since these historical details are now irrelevant, we no longer need
separate logic for the recipe and sandbox sides, and we don't need to
keep track of the recipe-bottom separate from the bottom margin of
arbitrary editors.
Diffstat (limited to 'linkify')
0 files changed, 0 insertions, 0 deletions