about summary refs log tree commit diff stats
path: root/057static_dispatch.cc
Commit message (Expand)AuthorAgeFilesLines
* 2617 - better error messagesKartik K. Agaram2016-01-301-0/+45
* 2616Kartik K. Agaram2016-01-301-0/+1
* 2603 - bugfix: defining main with commandline argsKartik K. Agaram2016-01-251-1/+1
* 2576 - distinguish allocated addresses from othersKartik K. Agaram2016-01-191-4/+4
* 2564Kartik K. Agaram2016-01-181-2/+0
* 2561Kartik K. Agaram2016-01-171-0/+5
* 2559 - stop using 'next-ingredient' explicitlyKartik K. Agaram2016-01-121-14/+4
* 2557 - type-check most ingredients ahead of timeKartik K. Agaram2016-01-121-38/+1
* 2553 - keep failed specializations from generating spurious errorsKartik K. Agaram2015-12-281-6/+0
* 2546 - another phase-ordering constraintKartik K. Agaram2015-12-191-1/+19
* three bugs fixedKartik K. Agaram2015-12-151-13/+48
* bugfix: phase orderingKartik K. Agaram2015-12-151-0/+43
* layer 3 of edit/ now workingKartik K. Agaram2015-12-151-0/+21
* 2610Kartik K. Agaram2015-11-291-5/+5
* 2608 - improve errors when static dispatch failsKartik K. Agaram2015-11-291-0/+50
* 2607 - resolve some edge cases in static dispatchKartik K. Agaram2015-11-291-6/+70
* 2499 - done reorganizing transformsKartik K. Agaram2015-11-281-2/+1
* 2487Kartik K. Agaram2015-11-271-4/+17
* 2483 - to-text can now handle listsKartik K. Agaram2015-11-271-5/+31
* 2482 - better choice between valid variantsKartik K. Agaram2015-11-271-2/+31
* 2481Kartik K. Agaram2015-11-271-2/+1
* 2472Kartik K. Agaram2015-11-221-2/+0
* 2470 - allow overloading primitive operationsKartik K. Agaram2015-11-221-3/+28
* 2445 - dispatch between shape-shifting variantsKartik K. Agaram2015-11-151-2/+8
* 2438 - specialize inside header-less recipesKartik K. Agaram2015-11-141-1/+0
* 2436Kartik K. Agaram2015-11-141-2/+2
* 2435Kartik K. Agaram2015-11-131-2/+2
* 2421 - 'generic' => 'shape-shifting'Kartik K. Agaram2015-11-101-1/+1
* 2418 - start raising errors on generic callsKartik K. Agaram2015-11-101-6/+7
* 2406Kartik K. Agaram2015-11-081-4/+2
* 2397Kartik K. Agaram2015-11-081-1/+3
* 2394 - clean up outputKartik K. Agaram2015-11-071-1/+0
* 2393 - redo 2391Kartik K. Agaram2015-11-071-1/+1
* 2392 - undo 2391Kartik K. Agaram2015-11-071-1/+1
* 2391Kartik K. Agaram2015-11-071-1/+1
* 2387 - edit/ passing except that final undo layerKartik K. Agaram2015-11-071-0/+2
* 2386 - core tests passing againKartik K. Agaram2015-11-071-2/+2
* 2383 - new concern: idempotence of transformsKartik K. Agaram2015-11-061-1/+1
* 2382Kartik K. Agaram2015-11-061-0/+1
* 2380 - done loading mu codeKartik K. Agaram2015-11-061-7/+7
* 2379 - further improvements to map operationsKartik K. Agaram2015-11-061-2/+2
* 2377 - stop using operator[] in mapKartik K. Agaram2015-11-061-18/+18
* 2366 - disallow static dispatch inside header-less recipesKartik K. Agaram2015-11-051-0/+1
* 2361Kartik K. Agaram2015-11-041-1/+2
* 2358 - starting to tackle the phase ordering problemKartik K. Agaram2015-11-041-2/+2
* 2350Kartik K. Agaram2015-11-041-1/+7
* 2342 - generalize generic recipesKartik K. Agaram2015-11-011-1/+1
* 2336Kartik K. Agaram2015-10-311-8/+18
* 2334Kartik K. Agaram2015-10-311-2/+2
* 2331 - generic recipe: first passing testKartik K. Agaram2015-10-311-0/+2
795f5244 ^
b8348923 ^
59874868 ^

c6520d96 ^

4a943d4e ^






































9edabeaa ^
93d4cc93 ^



1211a3ab ^
1fb0cf9e ^
c6034af3 ^
1b76245c ^
49659e72 ^
3076bab4 ^
9f7f62ed ^
49659e72 ^
a55bbd06 ^
f4647409 ^
1fb0cf9e ^
f4647409 ^

93d4cc93 ^

f4647409 ^
93d4cc93 ^
f4647409 ^




b8348923 ^

1211a3ab ^
1fb0cf9e ^
b8348923 ^
758e0fc6 ^
c36eb25c ^


4a943d4e ^








c36eb25c ^
f7c58ffd ^




4a943d4e ^











c36eb25c ^
f7c58ffd ^











93d4cc93 ^
f7c58ffd ^



758e0fc6 ^

8dccf184 ^

1211a3ab ^
8dccf184 ^




4a943d4e ^



























1e76d01d ^
7284d503 ^

4a943d4e ^
















































07d35c4a ^
1848b18f ^

a55bbd06 ^
795f5244 ^
b8515e8a ^
a55bbd06 ^
b8515e8a ^
2b250717 ^
e4630643 ^

3473c63a ^
15936c91 ^
1ad3fe9e ^
9dcbec39 ^
18e626df ^

3473c63a ^
15936c91 ^

9dcbec39 ^
15936c91 ^

fb85b3b4 ^
3473c63a ^
15936c91 ^
090cad5c ^
bb7142db ^
9dcbec39 ^
fb85b3b4 ^

b8515e8a ^



3473c63a ^
15936c91 ^
b24eb476 ^
c442a5ad ^
18e626df ^
2b250717 ^
46026f62 ^

3473c63a ^
15936c91 ^

15936c91 ^
2b250717 ^
551d155c ^

090cad5c ^
9f7f62ed ^
c442a5ad ^

fb1fcbc9 ^

a55bbd06 ^


7e9c6925 ^
3377364a ^
9f7f62ed ^



3377364a ^
93d4cc93 ^








9f7f62ed ^
93d4cc93 ^
9f7f62ed ^
7e9c6925 ^

b8348923 ^
34068eb3 ^
93d4cc93 ^


91ec4681 ^
93d4cc93 ^
b8348923 ^
93d4cc93 ^
b8348923 ^


34068eb3 ^
91ec4681 ^




23d3a022 ^
91ec4681 ^



93d4cc93 ^




4a943d4e ^





















































fb85b3b4 ^
5c6840b8 ^

4a943d4e ^








5c6840b8 ^
991d76f3 ^
1848b18f ^
4a943d4e ^










1848b18f ^

991d76f3 ^
a55bbd06 ^
991d76f3 ^
b8515e8a ^
991d76f3 ^

2b250717 ^
e4630643 ^

3473c63a ^
15936c91 ^
1ad3fe9e ^
9dcbec39 ^
46026f62 ^

3473c63a ^
15936c91 ^

9dcbec39 ^
991d76f3 ^

3473c63a ^
15936c91 ^
090cad5c ^
991d76f3 ^
9dcbec39 ^
fb85b3b4 ^

fc19980d ^

0d219477 ^


fc19980d ^
b8515e8a ^


991d76f3 ^
3473c63a ^
15936c91 ^
b24eb476 ^
18e626df ^
2b250717 ^
18e626df ^

3473c63a ^
15936c91 ^

15936c91 ^
2b250717 ^
551d155c ^

9f7f62ed ^
c442a5ad ^
991d76f3 ^

59874868 ^
991d76f3 ^
6e793202 ^
6c96a437 ^
c442a5ad ^
991d76f3 ^

59874868 ^
a55bbd06 ^
c8a58cdc ^
4a943d4e ^








































0d219477 ^
c8a58cdc ^

4a943d4e ^










c8a58cdc ^



795f5244 ^
b8515e8a ^
c8a58cdc ^
b8515e8a ^
2b250717 ^
e4630643 ^

3473c63a ^
15936c91 ^

9dcbec39 ^
c8a58cdc ^

b8515e8a ^



3473c63a ^
15936c91 ^

2b250717 ^
18e626df ^

cfb142b9 ^
15936c91 ^
c8a58cdc ^

e74a2940 ^




991d76f3 ^
e74a2940 ^
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635

                                                                              



                                                                               
 
                                               










                                                                                        



                                             
                                                  
                                       
                    
                              
                                                                                                                                                        

          
                                                
                                         
                              
                                                                                                                                   

          
                             
                                                                                                                   


                                                                   

                                                                 
                                                                                                                        

          


                                                          
                                                                                                                                                                                         

          



                                                
                                                                 
                                       
                                   



                                                                 
                                                       
                                                                                                            
                                                                
                                               
                                                                                             
                     
                                               
                                   
                              

                         

 






































                                                                               
 



                                                                                
                                                
                                                                                       
                       
                                                                                                             
             
   
                                                                                
 
 
                                                    
                                                                              

                                                

                                                                                                                                                           
                         
                                                      




                                  

                                                                          
                                              
                                                                                       
 
                             


                                                                           








                                                    
 




                                                                                                                        











                                                                     
 











                                                                                                                                        
                                                                                                     



                                                                                                                              

 

                                                                             
                                              




                                                                                              



























                                               
 

                                                
















































                                                                                                    
 

                                             
                                        
                                    
                                       
             
                                    
                                                                                                                                      

          
                                                
                               
                           
                                                                                                                

          
                                                 

                                
                                                                                                                                                   

          
                                   
                                                
                                  
                                                          
                                           
                                                                                                                                                                                                                                   

          



                                                
                                                                 
                             
                                
                                                                                 
                          
                                                                                                                                              

          
                                                                  

                                               
                                                                                      
                                                                                                                                                                          

          
                                                          
                                                                                             

                                                                                        

                                           


        
       
                                                      



                                                 
                      








                                                                                                                      
                             
   
                     

 
                                    
                                   


                                                                                                                                                                       
                         
                                                        
   
                                               


                                        
                          




                                   
                                                                       



                               




                                 





















































                                                                                                                     
 

                                                                              








                                         
 
                                               
 










                                                       

                                             
          
                                        
                                            
                                       

                                    
                                                                                                                                          

          
                                                
                                   
                           
                                                                                                                    

          
                                                 

                                    
                                                                                                                                                                               

          
                                                 
                                    
                                                          
                                         
                                                                                                                                                                                                                                                                                                                  

          

                                                                


                                                                                                                                                                                                                    
                                 


                                                
                 
                                                                 
                                 
                                
                          
                                                                                                                                              

          
                                                                  

                                               
                                                                                      
                                                                                                                                                                          

          
                                                                                                    
                                                                                  

                                                                            
                         
                                                                              
                                     
                                           
                                                                                                                         

                                        
        
 
 








































                                                                                                                                                        
 

                                   










                                         



                                             
                                      
                                       
              
                                    
                                                                                                                                       

          
                                                 

                                 
                                                                                                   

          



                                                
                                                                  

                               
                                                                                                                                              

          
                     
                                                               

        




                                                                             
                                                                     
               
//: Arrays contain a variable number of elements of the same type. Their value
//: starts with the length of the array.
//:
//: You can create arrays of containers, but containers can only contain
//: elements of a fixed size, so you can't create containers containing arrays.
//: Create containers containing addresses to arrays instead.

//: You can create arrays using 'create-array'.
void test_create_array() {
  run(
      "def main [\n"
      // create an array occupying locations 1 (for the size) and 2-4 (for the elements)
      "  1:array:num:3 <- create-array\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "run: creating array from 4 locations\n"
  );
}

:(before "End Primitive Recipe Declarations")
CREATE_ARRAY,
:(before "End Primitive Recipe Numbers")
put(Recipe_ordinal, "create-array", CREATE_ARRAY);
:(before "End Primitive Recipe Checks")
case CREATE_ARRAY: {
  if (inst.products.empty()) {
    raise << maybe(get(Recipe, r).name) << "'create-array' needs one product and no ingredients but got '" << to_original_string(inst) << '\n' << end();
    break;
  }
  reagent/*copy*/ product = inst.products.at(0);
  // Update CREATE_ARRAY product in Check
  if (!is_mu_array(product)) {
    raise << maybe(get(Recipe, r).name) << "'create-array' cannot create non-array '" << product.original_string << "'\n" << end();
    break;
  }
  if (!product.type->right) {
    raise << maybe(get(Recipe, r).name) << "create array of what? '" << to_original_string(inst) << "'\n" << end();
    break;
  }
  // 'create-array' will need to check properties rather than types
  type_tree* array_length_from_type = product.type->right->right;
  if (!array_length_from_type) {
    raise << maybe(get(Recipe, r).name) << "create array of what size? '" << to_original_string(inst) << "'\n" << end();
    break;
  }
  if (!product.type->right->right->atom)
    array_length_from_type = array_length_from_type->left;
  if (!is_integer(array_length_from_type->name)) {
    raise << maybe(get(Recipe, r).name) << "'create-array' product should specify size of array after its element type, but got '" << product.type->right->right->name << "'\n" << end();
    break;
  }
  break;
}
:(before "End Primitive Recipe Implementations")
case CREATE_ARRAY: {
  reagent/*copy*/ product = current_instruction().products.at(0);
  // Update CREATE_ARRAY product in Run
  int base_address = product.value;
  type_tree* array_length_from_type = product.type->right->right;
  if (!product.type->right->right->atom)
    array_length_from_type = array_length_from_type->left;
  int array_length = to_integer(array_length_from_type->name);
  // initialize array length, so that size_of will work
  trace(Callstack_depth+1, "mem") << "storing " << array_length << " in location " << base_address << end();
  put(Memory, base_address, array_length);  // in array elements
  int size = size_of(product);  // in locations
  trace(Callstack_depth+1, "run") << "creating array from " << size << " locations" << end();
  // initialize array
  for (int i = 1;  i <= size_of(product);  ++i)
    put(Memory, base_address+i, 0);
  // no need to update product
  write_products = false;
  break;
}

:(code)
// Arrays can be copied around with a single instruction just like numbers,
// no matter how large they are.
// You don't need to pass the size around, since each array variable stores its
// size in memory at run-time. We'll call a variable with an explicit size a
// 'static' array, and one without a 'dynamic' array since it can contain
// arrays of many different sizes.
void test_copy_array() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  2:num <- copy 14\n"
      "  3:num <- copy 15\n"
      "  4:num <- copy 16\n"
      "  5:array:num <- copy 1:array:num:3\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "mem: storing 3 in location 5\n"
      "mem: storing 14 in location 6\n"
      "mem: storing 15 in location 7\n"
      "mem: storing 16 in location 8\n"
  );
}

void test_stash_array() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  2:num <- copy 14\n"
      "  3:num <- copy 15\n"
      "  4:num <- copy 16\n"
      "  stash [foo:], 1:array:num:3\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "app: foo: 3 14 15 16\n"
  );
}

:(before "End types_coercible Special-cases")
if (is_mu_array(from) && is_mu_array(to))
  return types_strictly_match(array_element(from.type), array_element(to.type));

:(before "End size_of(reagent r) Special-cases")
if (!r.type->atom && r.type->left->atom && r.type->left->value == Array_type_ordinal) {
  if (!r.type->right) {
    raise << maybe(current_recipe_name()) << "'" << r.original_string << "' is an array of what?\n" << end();
    return 1;
  }
  return /*space for length*/1 + array_length(r)*size_of(array_element(r.type));
}

:(before "End size_of(type) Non-atom Special-cases")
if (type->left->value == Array_type_ordinal) return static_array_length(type);
:(code)
int static_array_length(const type_tree* type) {
  if (!type->atom && type->right && !type->right->atom && type->right->right && !type->right->right->atom && !type->right->right->right  // exactly 3 types
      && type->right->right->left && type->right->right->left->atom && is_integer(type->right->right->left->name)) {  // third 'type' is a number
    // get size from type
    return to_integer(type->right->right->left->name);
  }
  cerr << to_string(type) << '\n';
  assert(false);
}

//: disable the size mismatch check for arrays since the destination array
//: need not be initialized
:(before "End size_mismatch(x) Special-cases")
if (x.type && !x.type->atom && x.type->left->value == Array_type_ordinal) return false;

//:: arrays inside containers
//: arrays are disallowed inside containers unless their length is fixed in
//: advance

:(code)
void test_container_permits_static_array_element() {
  run(
      "container foo [\n"
      "  x:array:num:3\n"
      "]\n"
  );
  CHECK_TRACE_COUNT("error", 0);
}

:(before "End insert_container Special-cases")
else if (is_integer(type->name)) {  // sometimes types will contain non-type tags, like numbers for the size of an array
  type->value = 0;
}

:(code)
void test_container_disallows_dynamic_array_element() {
  Hide_errors = true;
  run(
      "container foo [\n"
      "  x:array:num\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: container 'foo' cannot determine size of element 'x'\n"
  );
}

:(before "End Load Container Element Definition")
{
  const type_tree* type = info.elements.back().type;
  if (type && type->atom && type->name == "array") {
    raise << "container '" << name << "' doesn't specify type of array elements for '" << info.elements.back().name << "'\n" << end();
    continue;
  }
  if (type && !type->atom && type->left->atom && type->left->name == "array") {
    if (!type->right) {
      raise << "container '" << name << "' doesn't specify type of array elements for '" << info.elements.back().name << "'\n" << end();
      continue;
    }
    if (!type->right->right || !is_integer(type->right->right->left->name)) {  // array has no length
      raise << "container '" << name << "' cannot determine size of element '" << info.elements.back().name << "'\n" << end();
      continue;
    }
  }
}

//: disable the size mismatch check for 'merge' instructions since containers
//: can contain arrays, and since we already do plenty of checking for them
:(before "End size_mismatch(x) Special-cases")
if (current_call().running_step_index < SIZE(get(Recipe, current_call().running_recipe).steps)
    && current_instruction().operation == MERGE) {
  return false;
}

:(code)
void test_merge_static_array_into_container() {
  run(
      "container foo [\n"
      "  x:num\n"
      "  y:array:num:3\n"
      "]\n"
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  10:foo <- merge 34, 1:array:num:3\n"
      "]\n"
  );
  // no errors
}

void test_code_inside_container() {
  Hide_errors = true;
  run(
      "container card [\n"
      "  rank:num <- next-ingredient\n"
      "]\n"
      "def foo [\n"
      "  1:card <- merge 3\n"
      "  2:num <- get 1:card rank:offset\n"
      "]\n"
  );
  // shouldn't die
}

//:: To access elements of an array, use 'index'

void test_index() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  2:num <- copy 14\n"
      "  3:num <- copy 15\n"
      "  4:num <- copy 16\n"
      "  10:num <- index 1:array:num:3, 0/index\n"  // the index must be a non-negative whole number
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "mem: storing 14 in location 10\n"
  );
}

void test_index_compound_element() {
  run(
      "def main [\n"
      "  {1: (array (address number) 3)} <- create-array\n"
      // skip alloc id
      "  3:num <- copy 14\n"
      // skip alloc id
      "  5:num <- copy 15\n"
      // skip alloc id
      "  7:num <- copy 16\n"
      "  10:address:num <- index {1: (array (address number) 3)}, 0\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      // skip alloc id
      "mem: storing 14 in location 11\n"
  );
}

void test_index_direct_offset() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  2:num <- copy 14\n"
      "  3:num <- copy 15\n"
      "  4:num <- copy 16\n"
      "  10:num <- copy 0\n"
      "  20:num <- index 1:array:num, 10:num\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "mem: storing 14 in location 20\n"
  );
}

:(before "End Primitive Recipe Declarations")
INDEX,
:(before "End Primitive Recipe Numbers")
put(Recipe_ordinal, "index", INDEX);
:(before "End Primitive Recipe Checks")
case INDEX: {
  if (SIZE(inst.ingredients) != 2) {
    raise << maybe(get(Recipe, r).name) << "'index' expects exactly 2 ingredients in '" << to_original_string(inst) << "'\n" << end();
    break;
  }
  reagent/*copy*/ base = inst.ingredients.at(0);
  // Update INDEX base in Check
  if (!is_mu_array(base)) {
    raise << maybe(get(Recipe, r).name) << "'index' on a non-array '" << base.original_string << "'\n" << end();
    break;
  }
  reagent/*copy*/ index = inst.ingredients.at(1);
  // Update INDEX index in Check
  if (!is_mu_number(index)) {
    raise << maybe(get(Recipe, r).name) << "second ingredient of 'index' should be a number, but got '" << index.original_string << "'\n" << end();
    break;
  }
  if (inst.products.empty()) break;
  reagent/*copy*/ product = inst.products.at(0);
  // Update INDEX product in Check
  reagent/*local*/ element(copy_array_element(base.type));
  if (!types_coercible(product, element)) {
    raise << maybe(get(Recipe, r).name) << "'index' on '" << base.original_string << "' can't be saved in '" << product.original_string << "'; type should be '" << names_to_string_without_quotes(element.type) << "'\n" << end();
    break;
  }
  break;
}
:(before "End Primitive Recipe Implementations")
case INDEX: {
  reagent/*copy*/ base = current_instruction().ingredients.at(0);
  // Update INDEX base in Run
  int base_address = base.value;
  trace(Callstack_depth+1, "run") << "base address is " << base_address << end();
  if (base_address == 0) {
    raise << maybe(current_recipe_name()) << "tried to access location 0 in '" << to_original_string(current_instruction()) << "'\n" << end();
    break;
  }
  reagent/*copy*/ index = current_instruction().ingredients.at(1);
  // Update INDEX index in Run
  vector<double> index_val(read_memory(index));
  if (index_val.at(0) < 0 || index_val.at(0) >= get_or_insert(Memory, base_address)) {
    raise << maybe(current_recipe_name()) << "invalid index " << no_scientific(index_val.at(0)) << " in '" << to_original_string(current_instruction()) << "'\n" << end();
    break;
  }
  reagent/*local*/ element(copy_array_element(base.type));
  element.set_value(base_address + /*skip length*/1 + index_val.at(0)*size_of(element.type));
  trace(Callstack_depth+1, "run") << "address to copy is " << element.value << end();
  trace(Callstack_depth+1, "run") << "its type is " << to_string(element.type) << end();
  // Read element
  products.push_back(read_memory(element));
  break;
}

:(code)
type_tree* copy_array_element(const type_tree* type) {
  return new type_tree(*array_element(type));
}

type_tree* array_element(const type_tree* type) {
  assert(type->right);
  if (type->right->atom) {
    return type->right;
  }
  else if (!type->right->right) {
    return type->right->left;
  }
  // hack: support array:num:3 without requiring extra parens
  else if (type->right->right->left && type->right->right->left->atom && is_integer(type->right->right->left->name)) {
    assert(!type->right->right->right);
    return type->right->left;
  }
  return type->right;
}

int array_length(const reagent& x) {
  // x should already be canonized.
  // hack: look for length in type
  if (!x.type->atom && x.type->right && !x.type->right->atom && x.type->right->right && !x.type->right->right->atom && !x.type->right->right->right  // exactly 3 types
      && x.type->right->right->left && x.type->right->right->left->atom && is_integer(x.type->right->right->left->name)) {  // third 'type' is a number
    // get size from type
    return to_integer(x.type->right->right->left->name);
  }
  // this should never happen at transform time
  return get_or_insert(Memory, x.value);
}

:(before "End Unit Tests")
void test_array_length_compound() {
  put(Memory, 1, 3);
  put(Memory, 2, 14);
  put(Memory, 3, 15);
  put(Memory, 4, 16);
  reagent x("1:array:address:num");  // 3 types, but not a static array
  populate_value(x);
  CHECK_EQ(array_length(x), 3);
}

void test_array_length_static() {
  reagent x("1:array:num:3");
  CHECK_EQ(array_length(x), 3);
}

void test_index_truncates() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  2:num <- copy 14\n"
      "  3:num <- copy 15\n"
      "  4:num <- copy 16\n"
      "  10:num <- index 1:array:num:3, 1.5\n"  // non-whole number
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      // fraction is truncated away
      "mem: storing 15 in location 10\n"
  );
}

void test_index_out_of_bounds() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:point:3 <- create-array\n"
      "  index 1:array:point:3, 4\n"  // less than size of array in locations, but larger than its length in elements
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: invalid index 4 in 'index 1:array:point:3, 4'\n"
  );
}

void test_index_out_of_bounds_2() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  index 1:array:num, -1\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: invalid index -1 in 'index 1:array:num, -1'\n"
  );
}

void test_index_product_type_mismatch() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:point:3 <- create-array\n"
      "  10:num <- index 1:array:point, 0\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: 'index' on '1:array:point' can't be saved in '10:num'; type should be 'point'\n"
  );
}

//: we might want to call 'index' without saving the results, say in a sandbox

void test_index_without_product() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  index 1:array:num:3, 0\n"
      "]\n"
  );
  // just don't die
}

//:: To write to elements of arrays, use 'put'.

void test_put_index() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  1:array:num <- put-index 1:array:num, 1, 34\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "mem: storing 34 in location 3\n"
  );
}

:(before "End Primitive Recipe Declarations")
PUT_INDEX,
:(before "End Primitive Recipe Numbers")
put(Recipe_ordinal, "put-index", PUT_INDEX);
:(before "End Primitive Recipe Checks")
case PUT_INDEX: {
  if (SIZE(inst.ingredients) != 3) {
    raise << maybe(get(Recipe, r).name) << "'put-index' expects exactly 3 ingredients in '" << to_original_string(inst) << "'\n" << end();
    break;
  }
  reagent/*copy*/ base = inst.ingredients.at(0);
  // Update PUT_INDEX base in Check
  if (!is_mu_array(base)) {
    raise << maybe(get(Recipe, r).name) << "'put-index' on a non-array '" << base.original_string << "'\n" << end();
    break;
  }
  reagent/*copy*/ index = inst.ingredients.at(1);
  // Update PUT_INDEX index in Check
  if (!is_mu_number(index)) {
    raise << maybe(get(Recipe, r).name) << "second ingredient of 'put-index' should have type 'number', but got '" << inst.ingredients.at(1).original_string << "'\n" << end();
    break;
  }
  reagent/*copy*/ value = inst.ingredients.at(2);
  // Update PUT_INDEX value in Check
  reagent/*local*/ element(copy_array_element(base.type));
  if (!types_coercible(element, value)) {
    raise << maybe(get(Recipe, r).name) << "'put-index " << base.original_string << ", " << inst.ingredients.at(1).original_string << "' should store " << names_to_string_without_quotes(element.type) << " but '" << value.name << "' has type " << names_to_string_without_quotes(value.type) << '\n' << end();
    break;
  }
  if (inst.products.empty()) break;  // no more checks necessary
  if (inst.products.at(0).name != inst.ingredients.at(0).name) {
    raise << maybe(get(Recipe, r).name) << "product of 'put-index' must be first ingredient '" << inst.ingredients.at(0).original_string << "', but got '" << inst.products.at(0).original_string << "'\n" << end();
    break;
  }
  // End PUT_INDEX Product Checks
  break;
}
:(before "End Primitive Recipe Implementations")
case PUT_INDEX: {
  reagent/*copy*/ base = current_instruction().ingredients.at(0);
  // Update PUT_INDEX base in Run
  int base_address = base.value;
  if (base_address == 0) {
    raise << maybe(current_recipe_name()) << "tried to access location 0 in '" << to_original_string(current_instruction()) << "'\n" << end();
    break;
  }
  reagent/*copy*/ index = current_instruction().ingredients.at(1);
  // Update PUT_INDEX index in Run
  vector<double> index_val(read_memory(index));
  if (index_val.at(0) < 0 || index_val.at(0) >= get_or_insert(Memory, base_address)) {
    raise << maybe(current_recipe_name()) << "invalid index " << no_scientific(index_val.at(0)) << " in '" << to_original_string(current_instruction()) << "'\n" << end();
    break;
  }
  int address = base_address + /*skip length*/1 + index_val.at(0)*size_of(array_element(base.type));
  trace(Callstack_depth+1, "run") << "address to copy to is " << address << end();
  // optimization: directly write the element rather than updating 'product'
  // and writing the entire array
  write_products = false;
  vector<double> value = read_memory(current_instruction().ingredients.at(2));
  // Write Memory in PUT_INDEX in Run
  for (int i = 0;  i < SIZE(value);  ++i) {
    trace(Callstack_depth+1, "mem") << "storing " << no_scientific(value.at(i)) << " in location " << address+i << end();
    put(Memory, address+i, value.at(i));
  }
  break;
}

:(code)
void test_put_index_out_of_bounds() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:point:3 <- create-array\n"
      "  8:point <- merge 34, 35\n"
      "  1:array:point <- put-index 1:array:point, 4, 8:point\n"  // '4' is less than size of array in locations, but larger than its length in elements
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: invalid index 4 in '1:array:point <- put-index 1:array:point, 4, 8:point'\n"
  );
}

void test_put_index_out_of_bounds_2() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:point:3 <- create-array\n"
      "  10:point <- merge 34, 35\n"
      "  1:array:point <- put-index 1:array:point, -1, 10:point\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: invalid index -1 in '1:array:point <- put-index 1:array:point, -1, 10:point'\n"
  );
}

void test_put_index_product_error() {
  Hide_errors = true;
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  4:array:num:3 <- put-index 1:array:num:3, 0, 34\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "error: main: product of 'put-index' must be first ingredient '1:array:num:3', but got '4:array:num:3'\n"
  );
}

//:: compute the length of an array

void test_array_length() {
  run(
      "def main [\n"
      "  1:array:num:3 <- create-array\n"
      "  10:num <- length 1:array:num\n"
      "]\n"
  );
  CHECK_TRACE_CONTENTS(
      "mem: storing 3 in location 10\n"
  );
}

:(before "End Primitive Recipe Declarations")
LENGTH,
:(before "End Primitive Recipe Numbers")
put(Recipe_ordinal, "length", LENGTH);
:(before "End Primitive Recipe Checks")
case LENGTH: {
  if (SIZE(inst.ingredients) != 1) {
    raise << maybe(get(Recipe, r).name) << "'length' expects exactly 2 ingredients in '" << to_original_string(inst) << "'\n" << end();
    break;
  }
  reagent/*copy*/ array = inst.ingredients.at(0);
  // Update LENGTH array in Check
  if (!is_mu_array(array)) {
    raise << "tried to calculate length of non-array '" << array.original_string << "'\n" << end();
    break;
  }
  break;
}
:(before "End Primitive Recipe Implementations")
case LENGTH: {
  reagent/*copy*/ array = current_instruction().ingredients.at(0);
  // Update LENGTH array in Run
  if (array.value == 0) {
    raise << maybe(current_recipe_name()) << "tried to access location 0 in '" << to_original_string(current_instruction()) << "'\n" << end();
    break;
  }
  products.resize(1);
  products.at(0).push_back(get_or_insert(Memory, array.value));
  break;
}

//: optimization: none of the instructions in this layer use 'ingredients' so
//: stop copying potentially huge arrays into it.
:(before "End should_copy_ingredients Special-cases")
recipe_ordinal r = current_instruction().operation;
if (r == CREATE_ARRAY || r == INDEX || r == PUT_INDEX || r == LENGTH)
  return false;