From 05d177737c980aad2fcdb54765433e02021ab1e0 Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Thu, 7 May 2015 15:49:40 -0700 Subject: 1299 - stop using [] in any vector Useful check: $ grep "[^ '\"]\[[^\"]" *.cc \ |perl -pwe 's/\Wargv\[|\WTests\[|\Wframe\[|\WMemory\[|\WName\[|\WSurrounding_space\[|\WRecipe\[|\WType\[|\WRecipe_number\[|\WType_number\[|\WBefore_fragments\[|\WAfter_fragments\[//g' \ |perl -pwe 's/\Wargv\[|\WTests\[|\Wframe\[|\WMemory\[|\WName\[|\WSurrounding_space\[|\WRecipe\[|\WType\[|\WRecipe_number\[|\WType_number\[|\WBefore_fragments\[|\WAfter_fragments\[//g' \ |grep '[^ ]\[' --- 003trace.test.cc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to '003trace.test.cc') diff --git a/003trace.test.cc b/003trace.test.cc index 0acf8807..db9bda2b 100644 --- a/003trace.test.cc +++ b/003trace.test.cc @@ -136,34 +136,34 @@ void test_trace_supports_count2() { void test_split_returns_at_least_one_elem() { vector result = split("", ","); CHECK_EQ(result.size(), 1); - CHECK_EQ(result[0], ""); + CHECK_EQ(result.at(0), ""); } void test_split_returns_entire_input_when_no_delim() { vector result = split("abc", ","); CHECK_EQ(result.size(), 1); - CHECK_EQ(result[0], "abc"); + CHECK_EQ(result.at(0), "abc"); } void test_split_works() { vector result = split("abc,def", ","); CHECK_EQ(result.size(), 2); - CHECK_EQ(result[0], "abc"); - CHECK_EQ(result[1], "def"); + CHECK_EQ(result.at(0), "abc"); + CHECK_EQ(result.at(1), "def"); } void test_split_works2() { vector result = split("abc,def,ghi", ","); CHECK_EQ(result.size(), 3); - CHECK_EQ(result[0], "abc"); - CHECK_EQ(result[1], "def"); - CHECK_EQ(result[2], "ghi"); + CHECK_EQ(result.at(0), "abc"); + CHECK_EQ(result.at(1), "def"); + CHECK_EQ(result.at(2), "ghi"); } void test_split_handles_multichar_delim() { vector result = split("abc,,def,,ghi", ",,"); CHECK_EQ(result.size(), 3); - CHECK_EQ(result[0], "abc"); - CHECK_EQ(result[1], "def"); - CHECK_EQ(result[2], "ghi"); + CHECK_EQ(result.at(0), "abc"); + CHECK_EQ(result.at(1), "def"); + CHECK_EQ(result.at(2), "ghi"); } -- cgit 1.4.1-2-gfad0