From c4e143d6ea0635cdb164cec1c62afd7461e605ad Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Sun, 21 Feb 2016 20:30:02 -0800 Subject: 2681 - drop reagent types from reagent properties All my attempts at staging this change failed with this humongous commit that took all day and involved debugging three monstrous bugs. Two of the bugs had to do with forgetting to check the type name in the implementation of shape-shifting recipes. Bug #2 in particular would cause core tests in layer 59 to fail -- only when I loaded up edit/! It got me to just hack directly on mu.cc until I figured out the cause (snapshot saved in mu.cc.modified). The problem turned out to be that I accidentally saved a type ingredient in the Type table during specialization. Now I know that that can be very bad. I've checked the traces for any stray type numbers (rather than names). I also found what might be a bug from last November (labeled TODO), but we'll verify after this commit. --- 040brace.cc | 1 - 1 file changed, 1 deletion(-) (limited to '040brace.cc') diff --git a/040brace.cc b/040brace.cc index 873c604c..6458e8ef 100644 --- a/040brace.cc +++ b/040brace.cc @@ -115,7 +115,6 @@ void transform_braces(const recipe_ordinal r) { // if implicit, compute target reagent target; target.type = new type_tree("offset", get(Type_ordinal, "offset")); - target.properties.at(0).second = new string_tree("offset"); target.set_value(0); if (open_braces.empty()) raise_error << inst.old_name << " needs a '{' before\n" << end(); -- cgit 1.4.1-2-gfad0