From 0059698b0b908904e68c8783deba2394e6d8dff5 Mon Sep 17 00:00:00 2001 From: Kartik Agaram Date: Tue, 13 Aug 2019 12:40:25 -0700 Subject: half-done testing get-or-stop Probably not needed for desugar; I'm just working through what we may replace the calls to 'get-slice' with if and when we decide to start focusing error messages and so writing tests for them. --- 078table.subx | 190 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ apps/assort | Bin 35424 -> 35848 bytes apps/crenshaw2-1 | Bin 29158 -> 29582 bytes apps/crenshaw2-1b | Bin 29717 -> 30141 bytes apps/dquotes | Bin 41980 -> 42404 bytes apps/factorial | Bin 28170 -> 28594 bytes apps/handle | Bin 29024 -> 29448 bytes apps/hex | Bin 37817 -> 38241 bytes apps/pack | Bin 48110 -> 48534 bytes apps/survey | Bin 44707 -> 45131 bytes apps/tests | Bin 34236 -> 34660 bytes 11 files changed, 190 insertions(+) diff --git a/078table.subx b/078table.subx index 092cc2ae..09903f81 100644 --- a/078table.subx +++ b/078table.subx @@ -13,6 +13,7 @@ # ------------------------+--------------------------------------------------- # abort | get get-slice # insert key | get-or-insert leaky-get-or-insert-slice +# stop | get-or-stop get-slice-or-stop # return null | maybe-get maybe-get-slice # Some variants may take extra args. @@ -921,6 +922,195 @@ $test-leaky-get-or-insert-slice:end: 5d/pop-to-EBP c3/return +# if no row is found, stop using 'ed' +get-or-stop: # table : (address stream {string, _}), key : (address string), row-size : int, + # abort-message-prefix : (address string), err : (address buffered-file), ed : (address exit-descriptor) + # -> EAX : (address _) + # pseudocode: + # curr = table->data + # max = &table->data[table->write] + # while curr < max + # if string-equal?(key, *curr) + # return curr+4 + # curr += row-size + # write-buffered(err, msg) + # stop(ed) + # + # . prolog + 55/push-EBP + 89/copy 3/mod/direct 5/rm32/EBP . . . 4/r32/ESP . . # copy ESP to EBP + # . save registers + 51/push-ECX + 52/push-EDX + 56/push-ESI + # ESI = table + 8b/copy 1/mod/*+disp8 5/rm32/EBP . . . 6/r32/ESI 8/disp8 . # copy *(EBP+8) to ESI + # curr/ECX = table->data + 8d/copy-address 1/mod/*+disp8 6/rm32/ESI . . . 1/r32/ECX 0xc/disp8 . # copy ESI+12 to ECX + # max/EDX = table->data + table->write + 8b/copy 0/mod/indirect 6/rm32/ESI . . . 2/r32/EDX . . # copy *ESI to EDX + 8d/copy-address 0/mod/indirect 4/rm32/sib 1/base/ECX 2/index/EDX . 2/r32/EDX . . # copy ECX+EDX to EDX +$get-or-stop:search-loop: + # if (curr >= max) stop(ed) + 39/compare 3/mod/direct 1/rm32/ECX . . . 2/r32/EDX . . # compare ECX with EDX + 73/jump-if-greater-or-equal-unsigned $get-or-stop:stop/disp8 + # if (string-equal?(key, *curr)) return curr+4 + # . EAX = string-equal?(key, *curr) + # . . push args + ff 6/subop/push 0/mod/indirect 1/rm32/ECX . . . . . . # push *ECX + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0xc/disp8 . # push *(EBP+12) + # . . call + e8/call string-equal?/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # . if (EAX != 0) return EAX = curr+4 + 3d/compare-EAX-and 0/imm32 + 74/jump-if-equal $get-or-stop:mismatch/disp8 + 8d/copy-address 1/mod/*+disp8 1/rm32/ECX . . . 0/r32/EAX 4/disp8 . # copy ECX+4 to EAX + eb/jump $get-or-stop:end/disp8 +$get-or-stop:mismatch: + # curr += row-size + 03/add 1/mod/*+disp8 5/rm32/EBP . . . 1/r32/ECX 0x10/disp8 . # add *(EBP+16) to ECX + # loop + eb/jump $get-or-stop:search-loop/disp8 +$get-or-stop:end: + # . restore registers + 5e/pop-to-ESI + 5a/pop-to-EDX + 59/pop-to-ECX + # . epilog + 89/copy 3/mod/direct 4/rm32/ESP . . . 5/r32/EBP . . # copy EBP to ESP + 5d/pop-to-EBP + c3/return + +$get-or-stop:stop: + # . write-buffered(err, abort-message-prefix) + # . . push args + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x14/disp8 . # push *(EBP+20) + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x18/disp8 . # push *(EBP+24) + # . . call + e8/call write-buffered/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # . write-buffered(err, error) + # . . push args + 68/push ": get: key not found: "/imm32 + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x18/disp8 . # push *(EBP+24) + # . . call + e8/call write-buffered/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # . write-buffered(err, key) + # . . push args + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0xc/disp8 . # push *(EBP+12) + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x18/disp8 . # push *(EBP+24) + # . . call + e8/call write-buffered/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # . write-buffered(err, "\n") + # . . push args + 68/push "\n"/imm32 + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x18/disp8 . # push *(EBP+24) + # . . call + e8/call write-buffered/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # . stop(ed, 1) + # . . push args + bb/copy-to-EBX 1/imm32 + ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 0x1c/disp8 . # push *(EBP+28) + # . . call + e8/call stop/disp32 + # never gets here +$get-or-stop:terminus: + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # syscall(exit, 1) + b8/copy-to-EAX 1/imm32/exit + cd/syscall 0x80/imm8 + +test-get-or-stop: + # This test uses exit-descriptors. Use EBP for setting up local variables. + # . prolog + 55/push-EBP + 89/copy 3/mod/direct 5/rm32/EBP . . . 4/r32/ESP . . # copy ESP to EBP + # - setup + # . clear-stream(_test-error-stream) + # . . push args + 68/push _test-error-stream/imm32 + # . . call + e8/call clear-stream/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 4/imm32 # add to ESP + # . clear-stream(_test-error-buffered-file+4) + # . . push args + b8/copy-to-EAX _test-error-buffered-file/imm32 + 05/add-to-EAX 4/imm32 + 50/push-EAX + # . . call + e8/call clear-stream/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 4/imm32 # add to ESP + # var table/ECX : (address stream {string, number}) = stream(2 rows * 8 bytes) + 81 5/subop/subtract 3/mod/direct 4/rm32/ESP . . . . . 0x10/imm32 # subtract from ESP + 68/push 0x10/imm32/length + 68/push 0/imm32/read + 68/push 0/imm32/write + 89/copy 3/mod/direct 1/rm32/ECX . . . 4/r32/ESP . . # copy ESP to ECX + # var ed/EDX : (address exit-descriptor) + 68/push 0/imm32 + 68/push 0/imm32 + 89/copy 3/mod/direct 2/rm32/EDX . . . 4/r32/ESP . . # copy ESP to EDX + # size 'ed' for the calls to 'get-or-stop' + # . tailor-exit-descriptor(ed, 24) + # . . push args + 68/push 0x18/imm32/nbytes-of-args-for-get-or-stop + 52/push-EDX + # . . call + e8/call tailor-exit-descriptor/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + # insert(table, "code", 8 bytes per row) + # . . push args + 68/push 8/imm32/row-size + 68/push "code"/imm32 + 51/push-ECX + # . . call + e8/call get-or-insert/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 0xc/imm32 # add to ESP +$test-get-or-stop:success: + # EAX = get-or-stop(table, "code", row-size=8, msg, _test-error-buffered-file, ed) + # . . push args + 52/push-EDX/ed + 68/push _test-error-buffered-file/imm32 + 68/push "foo"/imm32 + 68/push 8/imm32/row-size + 68/push "code"/imm32 + 51/push-ECX + # . . call + e8/call get-or-stop/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 0x18/imm32 # add to ESP + # check-ints-equal(EAX - table->data, 4, msg) + # . check-ints-equal(EAX - table, 16, msg) + # . . push args + 68/push "F - test-get-or-stop/0"/imm32 + 68/push 0x10/imm32 + 29/subtract 3/mod/direct 0/rm32/EAX . . . 1/r32/ECX . . # subtract ECX from EAX + 50/push-EAX + # . . call + e8/call check-ints-equal/disp32 + # . . discard args + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 0xc/imm32 # add to ESP +$test-get-or-stop:end: + # . epilog + # don't restore ESP from EBP; manually reclaim locals + 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 0x24/imm32 # add to ESP + 5d/pop-to-EBP + c3/return + # if no row is found, return null (0) maybe-get: # table : (address stream {string, _}), key : (address string), row-size : int -> EAX : (address _) # pseudocode: diff --git a/apps/assort b/apps/assort index 267733ab..5a4ff14e 100755 Binary files a/apps/assort and b/apps/assort differ diff --git a/apps/crenshaw2-1 b/apps/crenshaw2-1 index 22cd3a7d..a1919314 100755 Binary files a/apps/crenshaw2-1 and b/apps/crenshaw2-1 differ diff --git a/apps/crenshaw2-1b b/apps/crenshaw2-1b index 589c7193..e806dd96 100755 Binary files a/apps/crenshaw2-1b and b/apps/crenshaw2-1b differ diff --git a/apps/dquotes b/apps/dquotes index c56cb9de..156efcf6 100755 Binary files a/apps/dquotes and b/apps/dquotes differ diff --git a/apps/factorial b/apps/factorial index a12110fa..ef2f24a7 100755 Binary files a/apps/factorial and b/apps/factorial differ diff --git a/apps/handle b/apps/handle index c5c5b78c..2243ab53 100755 Binary files a/apps/handle and b/apps/handle differ diff --git a/apps/hex b/apps/hex index d0ab0a32..d0472e49 100755 Binary files a/apps/hex and b/apps/hex differ diff --git a/apps/pack b/apps/pack index 65ae8cfc..1174a82a 100755 Binary files a/apps/pack and b/apps/pack differ diff --git a/apps/survey b/apps/survey index cf8c7a4b..f23e4590 100755 Binary files a/apps/survey and b/apps/survey differ diff --git a/apps/tests b/apps/tests index 563bfe04..193bb969 100755 Binary files a/apps/tests and b/apps/tests differ -- cgit 1.4.1-2-gfad0