From 6070c23e5e1c60d3bb169e43bddfa59b1d322427 Mon Sep 17 00:00:00 2001 From: Kartik Agaram Date: Thu, 16 Jan 2020 18:31:12 -0800 Subject: 5897 - rename comparison instructions Signed and unsigned don't quite capture the essence of what the different combinations of x86 flags are doing for SubX. The crucial distinction is that one set of comparison operators is for integers and the second is for addresses. --- html/052kernel-string-equal.subx.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'html/052kernel-string-equal.subx.html') diff --git a/html/052kernel-string-equal.subx.html b/html/052kernel-string-equal.subx.html index f7818771..ff234b34 100644 --- a/html/052kernel-string-equal.subx.html +++ b/html/052kernel-string-equal.subx.html @@ -140,17 +140,17 @@ if ('onhashchange' in window) { 78 $kernel-string-equal?:loop: 79 # if (i >= n) break 80 39/compare 3/mod/direct 1/rm32/ecx . . . 2/r32/edx . . # compare ecx with edx - 81 7d/jump-if-greater-or-equal $kernel-string-equal?:break/disp8 + 81 7d/jump-if->= $kernel-string-equal?:break/disp8 82 # c1 = *s1 83 8a/copy-byte 0/mod/indirect 7/rm32/edi . . . 0/r32/AL . . # copy byte at *edi to AL 84 # c2 = *s2 85 8a/copy-byte 0/mod/indirect 6/rm32/esi . . . 3/r32/BL . . # copy byte at *esi to BL 86 # if (c1 == 0) return false 87 3d/compare-eax-and 0/imm32 - 88 74/jump-if-equal $kernel-string-equal?:false/disp8 + 88 74/jump-if-= $kernel-string-equal?:false/disp8 89 # if (c1 != c2) return false 90 39/compare 3/mod/direct 0/rm32/eax . . . 3/r32/ebx . . # compare eax and ebx - 91 75/jump-if-not-equal $kernel-string-equal?:false/disp8 + 91 75/jump-if-!= $kernel-string-equal?:false/disp8 92 # ++i 93 41/increment-ecx 94 # ++s1 @@ -162,7 +162,7 @@ if ('onhashchange' in window) { 100 # return *s1 == 0 101 8a/copy-byte 0/mod/indirect 7/rm32/edi . . . 0/r32/AL . . # copy byte at *edi to AL 102 3d/compare-eax-and 0/imm32 -103 75/jump-if-not-equal $kernel-string-equal?:false/disp8 +103 75/jump-if-!= $kernel-string-equal?:false/disp8 104 $kernel-string-equal?:true: 105 b8/copy-to-eax 1/imm32 106 eb/jump $kernel-string-equal?:end/disp8 -- cgit 1.4.1-2-gfad0