From 6070c23e5e1c60d3bb169e43bddfa59b1d322427 Mon Sep 17 00:00:00 2001 From: Kartik Agaram Date: Thu, 16 Jan 2020 18:31:12 -0800 Subject: 5897 - rename comparison instructions Signed and unsigned don't quite capture the essence of what the different combinations of x86 flags are doing for SubX. The crucial distinction is that one set of comparison operators is for integers and the second is for addresses. --- html/085next-word-or-string.subx.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'html/085next-word-or-string.subx.html') diff --git a/html/085next-word-or-string.subx.html b/html/085next-word-or-string.subx.html index 640b2745..4671ca51 100644 --- a/html/085next-word-or-string.subx.html +++ b/html/085next-word-or-string.subx.html @@ -91,7 +91,7 @@ if ('onhashchange' in window) { 32 8b/copy 1/mod/*+disp8 6/rm32/esi . . . 0/r32/eax 4/disp8 . # copy *(esi+4) to eax 33 # . if (eax < line->write) goto next check 34 3b/compare 0/mod/indirect 6/rm32/esi . . . 0/r32/eax . . # compare eax with *esi - 35 7c/jump-if-lesser $next-word-or-string:check-for-comment/disp8 + 35 7c/jump-if-< $next-word-or-string:check-for-comment/disp8 36 # . return out 37 c7 0/subop/copy 0/mod/direct 7/rm32/edi . . . . . 0/imm32 # copy to *edi 38 c7 0/subop/copy 1/mod/*+disp8 7/rm32/edi . . . . 4/disp8 0/imm32 # copy to *(edi+4) @@ -107,7 +107,7 @@ if ('onhashchange' in window) { 48 8a/copy-byte 1/mod/*+disp8 4/rm32/sib 6/base/esi 1/index/ecx . 0/r32/AL 0xc/disp8 . # copy byte at *(esi+ecx+12) to AL 49 # . compare 50 3d/compare-eax-and 0x23/imm32/pound - 51 75/jump-if-not-equal $next-word-or-string:check-for-string-literal/disp8 + 51 75/jump-if-!= $next-word-or-string:check-for-string-literal/disp8 52 $next-word-or-string:comment: 53 # out->end = &line->data[line->write] 54 8b/copy 0/mod/indirect 6/rm32/esi . . . 0/r32/eax . . # copy *esi to eax @@ -125,7 +125,7 @@ if ('onhashchange' in window) { 66 8a/copy-byte 1/mod/*+disp8 4/rm32/sib 6/base/esi 1/index/ecx . 0/r32/AL 0xc/disp8 . # copy byte at *(esi+ecx+12) to AL 67 # . compare 68 3d/compare-eax-and 0x22/imm32/dquote - 69 75/jump-if-not-equal $next-word-or-string:regular-word/disp8 + 69 75/jump-if-!= $next-word-or-string:regular-word/disp8 70 $next-word-or-string:string-literal: 71 # skip-string(line) 72 # . . push args -- cgit 1.4.1-2-gfad0