From 6070c23e5e1c60d3bb169e43bddfa59b1d322427 Mon Sep 17 00:00:00 2001 From: Kartik Agaram Date: Thu, 16 Jan 2020 18:31:12 -0800 Subject: 5897 - rename comparison instructions Signed and unsigned don't quite capture the essence of what the different combinations of x86 flags are doing for SubX. The crucial distinction is that one set of comparison operators is for integers and the second is for addresses. --- html/apps/ex11.subx.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'html/apps/ex11.subx.html') diff --git a/html/apps/ex11.subx.html b/html/apps/ex11.subx.html index 84519e0e..d9c64f2a 100644 --- a/html/apps/ex11.subx.html +++ b/html/apps/ex11.subx.html @@ -135,17 +135,17 @@ if ('onhashchange' in window) { 73 $kernel-string-equal?:loop: 74 # if (i >= n) break 75 39/compare 3/mod/direct 1/rm32/ecx . . . 2/r32/edx . . # compare ecx with edx - 76 7d/jump-if-greater-or-equal $kernel-string-equal?:break/disp8 + 76 7d/jump-if->= $kernel-string-equal?:break/disp8 77 # c1 = *s1 78 8a/copy-byte 0/mod/indirect 7/rm32/edi . . . 0/r32/AL . . # copy byte at *edi to AL 79 # c2 = *s2 80 8a/copy-byte 0/mod/indirect 6/rm32/esi . . . 3/r32/BL . . # copy byte at *esi to BL 81 # if (c1 == 0) return false 82 3d/compare-eax-and 0/imm32 - 83 74/jump-if-equal $kernel-string-equal?:false/disp8 + 83 74/jump-if-= $kernel-string-equal?:false/disp8 84 # if (c1 != c2) return false 85 39/compare 3/mod/direct 0/rm32/eax . . . 3/r32/ebx . . # compare eax and ebx - 86 75/jump-if-not-equal $kernel-string-equal?:false/disp8 + 86 75/jump-if-!= $kernel-string-equal?:false/disp8 87 # ++i 88 41/increment-ecx 89 # ++s1 @@ -157,7 +157,7 @@ if ('onhashchange' in window) { 95 # return *s1 == 0 96 8a/copy-byte 0/mod/indirect 7/rm32/edi . . . 0/r32/AL . . # copy byte at *edi to AL 97 3d/compare-eax-and 0/imm32 - 98 75/jump-if-not-equal $kernel-string-equal?:false/disp8 + 98 75/jump-if-!= $kernel-string-equal?:false/disp8 99 $kernel-string-equal?:true: 100 b8/copy-to-eax 1/imm32 101 eb/jump $kernel-string-equal?:end/disp8 -- cgit 1.4.1-2-gfad0