//:: Check that the different operands of an instruction aren't too large for their bitfields. :(scenario check_bitfield_sizes) % Hide_errors = true; == 0x1 01/add 4/mod +error: '4/mod' too large to fit in bitfield mod :(before "End Globals") map Operand_bound; :(before "End One-time Setup") put(Operand_bound, "subop", 1<<3); put(Operand_bound, "mod", 1<<2); put(Operand_bound, "rm32", 1<<3); put(Operand_bound, "base", 1<<3); put(Operand_bound, "index", 1<<3); put(Operand_bound, "scale", 1<<2); put(Operand_bound, "r32", 1<<3); put(Operand_bound, "disp8", 1<<8); put(Operand_bound, "disp16", 1<<16); // no bound needed for disp32 put(Operand_bound, "imm8", 1<<8); // no bound needed for imm32 :(before "End One-time Setup") Transform.push_back(check_operand_bounds); :(code) void check_operand_bounds(/*const*/ program& p) { if (p.segments.empty()) return; const segment& seg = p.segments.at(0); for (int i = 0; i < SIZE(seg.lines); ++i) { const line& inst = seg.lines.at(i); for (int i = first_operand(inst); i < SIZE(inst.words); ++i) check_operand_bounds(inst.words.at(i)); if (trace_contains_errors()) return; // stop at the first mal-formed instruction } } void check_operand_bounds(const word& w) { for (map::iterator p = Operand_bound.begin(); p != Operand_bound.end(); ++p) { if (has_metadata(w, p->first)) { int32_t x = parse_int(w.data); if (x >= 0) { if (static_cast(x) >= p->second) raise << "'" << w.original << "' too large to fit in bitfield " << p->first << '\n' << end(); } else { // hacky? assuming bound is a power of 2 if (x < -1*static_cast(p->second/2)) raise << "'" << w.original << "' too large to fit in bitfield " << p->first << '\n' << end(); } } } } int32_t parse_int(const string& s) { istringstream in(s); int32_t result = 0; if (starts_with(s, "0x")) in >> std::hex; in >> result; if (!in) { raise << "not a number: " << s << '\n' << end(); return 0; } return result; }