From 52f876302f7e6da1f8f418d9dc85f0698c494e15 Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Sat, 31 Aug 2024 19:16:20 -0700 Subject: clean up some issues I now feel confident about --- README.md | 7 ------- undo.lua | 3 +-- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/README.md b/README.md index de57872..7e9ac31 100644 --- a/README.md +++ b/README.md @@ -51,13 +51,6 @@ found anything amiss: http://akkartik.name/contact * No support yet for right-to-left languages. -* Undo/redo may be sluggish in large files. Large files may grow sluggish in - other ways. lines.love works well in all circumstances with files under - 50KB. - -* If you kill the process, say by force-quitting because things things get - sluggish, you can lose data. - * The text cursor will always stay on the screen. This can have some strange implications: diff --git a/undo.lua b/undo.lua index d91fecd..59ca481 100644 --- a/undo.lua +++ b/undo.lua @@ -1,8 +1,7 @@ -- undo/redo by managing the sequence of events in the current session -- based on https://github.com/akkartik/mu1/blob/master/edit/012-editor-undo.mu --- Incredibly inefficient; we make a copy of lines on every single keystroke. --- The hope here is that we're either editing small files or just reading large files. +-- makes a copy of lines on every single keystroke; will be inefficient with really long lines. -- TODO: highlight stuff inserted by any undo/redo operation -- TODO: coalesce multiple similar operations -- cgit 1.4.1-2-gfad0