From a8747478ff6452c8bce106ffc9d889886ab202a8 Mon Sep 17 00:00:00 2001 From: "Kartik K. Agaram" Date: Mon, 10 Jul 2023 16:24:20 -0700 Subject: bugfix: Windows pushing title bar off screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I'm learning the hard way that resizing the window is a big deal. Only do this when someone explicitly requests it, otherwise follow LÖVE's defaults. Therefore we're also going to stop trying to be smart when showing the log browser. Leave window resizing to manual operations. Now initialization looks a lot more similar for the run and source apps. --- source_tests.lua | 35 +---------------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) (limited to 'source_tests.lua') diff --git a/source_tests.lua b/source_tests.lua index bf3ae3e..e3264bb 100644 --- a/source_tests.lua +++ b/source_tests.lua @@ -19,7 +19,6 @@ end function test_show_log_browser_side() App.screen.init{width=300, height=300} - Display_width = App.screen.width Current_app = 'source' Editor_state = edit.initialize_test_state() Editor_state.filename = 'foo' @@ -34,41 +33,9 @@ function test_show_log_browser_side() check(Show_log_browser_side, 'check') end -function test_show_log_browser_side_doubles_window_width_if_possible() - -- initialize screen dimensions to half width - App.screen.init{width=300, height=300} - Display_width = App.screen.width*2 - -- initialize source app with left side occupying entire window (half the display) - Current_app = 'source' - Editor_state = edit.initialize_test_state() - Editor_state.filename = 'foo' - Editor_state.left = Margin_left - Editor_state.right = App.screen.width - Margin_right - local old_editor_right = Editor_state.right - Text.redraw_all(Editor_state) - Log_browser_state = edit.initialize_test_state() - -- log browser has some arbitrary margins - Log_browser_state.left = 200 + Margin_left - Log_browser_state.right = 400 - Text.redraw_all(Log_browser_state) - log_browser.parse(Log_browser_state) - -- display log browser - Current_time = Current_time + 0.1 - App.run_after_keychord('C-l') - -- window width is doubled - check_eq(App.screen.width, 600, 'display:width') - -- left side margins are unchanged - check_eq(Editor_state.left, Margin_left, 'edit:left') - check_eq(Editor_state.right, old_editor_right, 'edit:right') - -- log browser margins are adjusted - check_eq(Log_browser_state.left, App.screen.width/2 + Margin_left, 'log:left') - check_eq(Log_browser_state.right, App.screen.width - Margin_right, 'log:right') -end - -function test_show_log_browser_side_resizes_both_sides_if_cannot_double_window_width() +function test_show_log_browser_side_splits_window_width() -- initialize screen dimensions and indicate that it is maximized App.screen.init{width=300, height=300} - Display_width = 300 -- initialize source app with left side occupying more than half the display Current_app = 'source' Editor_state = edit.initialize_test_state() -- cgit 1.4.1-2-gfad0