<feed xmlns='http://www.w3.org/2005/Atom'>
<title>aerc/worker/notmuch, branch master</title>
<subtitle>mirror of ~rjarry's aerc fork - a pretty good email client
</subtitle>
<id>https://git.tilde.institute/akspecs/aerc/atom?h=master</id>
<link rel='self' href='https://git.tilde.institute/akspecs/aerc/atom?h=master'/>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/'/>
<updated>2021-12-11T22:24:08Z</updated>
<entry>
<title>format: reformat code with go 1.17</title>
<updated>2021-12-11T22:24:08Z</updated>
<author>
<name>Robin Jarry</name>
<email>robin@jarry.cc</email>
</author>
<published>2021-12-11T22:20:53Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=b331371a6585b6a0cba678b2deba332e470a478b'/>
<id>urn:sha1:b331371a6585b6a0cba678b2deba332e470a478b</id>
<content type='text'>
There was a change in how build tags are formatted. Use this as new
reference.

Link: https://go.dev/doc/go1.17#gofmt
Signed-off-by: Robin Jarry &lt;robin@jarry.cc&gt;
</content>
</entry>
<entry>
<title>notmuch: allow sort by file order</title>
<updated>2021-11-13T14:25:04Z</updated>
<author>
<name>Kalyan Sriram</name>
<email>kalyan@coderkalyan.com</email>
</author>
<published>2021-11-13T08:10:09Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=402612fd9788f071a5d7ae0045989977b98d896f'/>
<id>urn:sha1:402612fd9788f071a5d7ae0045989977b98d896f</id>
<content type='text'>
When using the notmuch backend, it often makes more sense to sort
folders (actual virtual folders, or queries) by the order specified in
the query-map file, rather than alphabetically. This patch introduces a
configuration option (disabled by default) that allows this.

Additionally, due to the notmuch backend previously using maps (which
are order-undefined) to store the list of queries, default query
selection on aerc startup fluctuated. This patch fixes that by using
slices to store query order.
</content>
</entry>
<entry>
<title>notmuch: allow empty searches</title>
<updated>2021-11-13T14:20:54Z</updated>
<author>
<name>Kalyan Sriram</name>
<email>kalyan@coderkalyan.com</email>
</author>
<published>2021-11-13T06:31:16Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=d7bda10f3e1f76f70fa67908d1631632e8498d16'/>
<id>urn:sha1:d7bda10f3e1f76f70fa67908d1631632e8498d16</id>
<content type='text'>
Don't error on empty search terms, just don't filter
by anything and return all items matching the current querymap
</content>
</entry>
<entry>
<title>messages: allow displaying email threads</title>
<updated>2021-11-13T14:05:59Z</updated>
<author>
<name>y0ast</name>
<email>joost@joo.st</email>
</author>
<published>2021-11-12T17:12:02Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=dc2a2c2dfd6dc327fe40fbf2da922ef6c3d520be'/>
<id>urn:sha1:dc2a2c2dfd6dc327fe40fbf2da922ef6c3d520be</id>
<content type='text'>
Display threads in the message list. For now, only supported by the
notmuch backend and on IMAP when the server supports the THREAD
extension.

Setting threading-enable=true is global and will cause the message list
to be empty with maildir:// accounts.

Co-authored-by: Kevin Kuehler &lt;keur@xcf.berkeley.edu&gt;
Co-authored-by: Reto Brunner &lt;reto@labrat.space&gt;
Signed-off-by: Robin Jarry &lt;robin@jarry.cc&gt;
</content>
</entry>
<entry>
<title>go.mod: change base git url</title>
<updated>2021-11-05T09:21:45Z</updated>
<author>
<name>Robin Jarry</name>
<email>robin@jarry.cc</email>
</author>
<published>2021-11-05T09:19:46Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=0d645bcebda8d764c4f21f71ded1e3627d6e8837'/>
<id>urn:sha1:0d645bcebda8d764c4f21f71ded1e3627d6e8837</id>
<content type='text'>
I'm not sure what are the implications but it seems required.

Link: https://github.com/golang/go/issues/20883
Signed-off-by: Robin Jarry &lt;robin@jarry.cc&gt;
</content>
</entry>
<entry>
<title>notmuch/maildir: remove double emit of the dirinfo</title>
<updated>2021-04-28T05:54:16Z</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2021-04-26T19:36:00Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=1687e558d3fae4d5622677c031bb9365a8c3e261'/>
<id>urn:sha1:1687e558d3fae4d5622677c031bb9365a8c3e261</id>
<content type='text'>
There was some bug which could be worked around by double emitting an event.
However that proofed to be brittle:

We send the first message here from the worker goroutine:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.g=
o#L306

Then Tick() is waked in the main goroutine and calls ProcessMessage:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/widgets/account.go#L100

ProcessMessage in the main goroutine reads types.Message state with
msg.getId() and msg.InResponseTo():
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/types/worker.go#=
L74-76

Meanwhile in the worker goroutine we call PostMessage for a second
time with a pointer that points to the *same* previous message that
ProcessMessage is reading:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.g=
o#L306

The second PostMessage call makes writes to message while
ProcessMessage in the main goroutine is possibly reading:
https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/types/worker.go#=
L59

This led to a data race in the event loop

Reported-By: Wagner Riffel &lt;w@104d.net&gt;
</content>
</entry>
<entry>
<title>notmuch: don't read the full file into memory</title>
<updated>2021-02-08T07:40:07Z</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2021-02-08T07:40:07Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=db6848fe1b77bc7f2a657231307d2a4271d41482'/>
<id>urn:sha1:db6848fe1b77bc7f2a657231307d2a4271d41482</id>
<content type='text'>
</content>
</entry>
<entry>
<title>notmuch: trim excluded tags</title>
<updated>2020-12-02T08:08:19Z</updated>
<author>
<name>Kalyan Sriram</name>
<email>kalyan@coderkalyan.com</email>
</author>
<published>2020-11-28T19:33:48Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=b56a688589c946ff8224f3d9e2e73de2edbc39b4'/>
<id>urn:sha1:b56a688589c946ff8224f3d9e2e73de2edbc39b4</id>
<content type='text'>
Trims whitespace in list of excluded notmuch tags. This allows a comma
separated list with spaces to be correctly processed.
</content>
</entry>
<entry>
<title>notmuch: remove gc close hooks</title>
<updated>2020-12-02T08:06:34Z</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-11-26T06:31:05Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=a9330f4c63816ed79f6d150e998f003bea9478dd'/>
<id>urn:sha1:a9330f4c63816ed79f6d150e998f003bea9478dd</id>
<content type='text'>
We frequently had issues with notmuch segfaulting and my guess is that this
was due to the garbage collection magic used in the module.

This changes to a fork that ripped the functionality out.
</content>
</entry>
<entry>
<title>notmuch: rename method to SetFlag</title>
<updated>2020-09-27T17:00:58Z</updated>
<author>
<name>Reto Brunner</name>
<email>reto@labrat.space</email>
</author>
<published>2020-09-27T17:00:58Z</published>
<link rel='alternate' type='text/html' href='https://git.tilde.institute/akspecs/aerc/commit/?id=c48f228fa5ac57984af78e19713929224874aa8b'/>
<id>urn:sha1:c48f228fa5ac57984af78e19713929224874aa8b</id>
<content type='text'>
</content>
</entry>
</feed>
