From 550ef0bc1f21dfaeb1bf216b28c3fce9a816cb73 Mon Sep 17 00:00:00 2001 From: Frode Aannevik Date: Sun, 13 Oct 2019 20:01:16 +0200 Subject: Fix: oauthbearer runtime error Configure an oauthbearer source without a token_endpoint parameter would panic due to nil pointer dereference Example source=imaps+oauthbearer://frode.aa%40gmail.com@imap.gmail.com:993 source-cred-cmd=pass oatuh2 frode.aa@gmail.com token_endpoint is not required as it will use the provided password as access_token when it is not set --- worker/imap/worker.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/worker/imap/worker.go b/worker/imap/worker.go index cd63c39..4d3e51c 100644 --- a/worker/imap/worker.go +++ b/worker/imap/worker.go @@ -85,14 +85,15 @@ func (w *IMAPWorker) handleMessage(msg types.WorkerMessage) error { w.config.scheme = strings.TrimSuffix(w.config.scheme, "+oauthbearer") w.config.oauthBearer.Enabled = true q := u.Query() + + oauth2 := &oauth2.Config{} if q.Get("token_endpoint") != "" { - w.config.oauthBearer.OAuth2 = &oauth2.Config{ - ClientID: q.Get("client_id"), - ClientSecret: q.Get("client_secret"), - Scopes: []string{q.Get("scope")}, - } - w.config.oauthBearer.OAuth2.Endpoint.TokenURL = q.Get("token_endpoint") + oauth2.ClientID = q.Get("client_id") + oauth2.ClientSecret = q.Get("client_secret") + oauth2.Scopes = []string{q.Get("scope")} + oauth2.Endpoint.TokenURL = q.Get("token_endpoint") } + w.config.oauthBearer.OAuth2 = oauth2 } w.config.addr = u.Host -- cgit 1.4.1-2-gfad0