From ea2646fc039a572491ba8cc8e2879b7bf61c25dd Mon Sep 17 00:00:00 2001 From: Reto Brunner Date: Sat, 9 May 2020 11:50:31 +0200 Subject: Change MarkedMessages to return uids Especially if one tries to interact with all marked messages there could be the case that not all headers are fetched yet, hence the messageInfo is still nil. This segfaults a lot of commands which in principle only need the uid to complete. If we switch to uids, this issue can be alleviated for those commands. --- widgets/account.go | 4 ++-- widgets/msgviewer.go | 4 ++-- widgets/providesmessage.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'widgets') diff --git a/widgets/account.go b/widgets/account.go index 31384a5..20ed345 100644 --- a/widgets/account.go +++ b/widgets/account.go @@ -215,9 +215,9 @@ func (acct *AccountView) SelectedMessage() (*models.MessageInfo, error) { return msg, nil } -func (acct *AccountView) MarkedMessages() ([]*models.MessageInfo, error) { +func (acct *AccountView) MarkedMessages() ([]uint32, error) { store := acct.Store() - return msgInfoFromUids(store, store.Marked()) + return store.Marked(), nil } func (acct *AccountView) SelectedMessagePart() *PartInfo { diff --git a/widgets/msgviewer.go b/widgets/msgviewer.go index e192ae6..0cfabd7 100644 --- a/widgets/msgviewer.go +++ b/widgets/msgviewer.go @@ -262,9 +262,9 @@ func (mv *MessageViewer) SelectedMessage() (*models.MessageInfo, error) { return mv.msg.MessageInfo(), nil } -func (mv *MessageViewer) MarkedMessages() ([]*models.MessageInfo, error) { +func (mv *MessageViewer) MarkedMessages() ([]uint32, error) { store := mv.Store() - return msgInfoFromUids(store, store.Marked()) + return store.Marked(), nil } func (mv *MessageViewer) ToggleHeaders() { diff --git a/widgets/providesmessage.go b/widgets/providesmessage.go index b06825f..6e00b1c 100644 --- a/widgets/providesmessage.go +++ b/widgets/providesmessage.go @@ -25,5 +25,5 @@ type ProvidesMessages interface { Store() *lib.MessageStore SelectedAccount() *AccountView SelectedMessage() (*models.MessageInfo, error) - MarkedMessages() ([]*models.MessageInfo, error) + MarkedMessages() ([]uint32, error) } -- cgit 1.4.1-2-gfad0