about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* browsercolumn: Use number of items for widthtoonn2022-05-271-1/+1
| | | | | | | | The width of the widest line number, which is often the last one visible in the list is not always the same thing as the width of the item that would be at the very bottom of the screen. When a directory contains fewer items than lines are available for display, the former can have fewer digits.
* browsercolumn: Take into account one_indexed settingtoonn2022-05-271-2/+5
| | | | | Line number width calculation was ignoring the one_indexed setting. This meant recalculating the width one line too late.
* browsercolumn: Lowercase line_numbers in keytoonn2022-05-271-1/+1
| | | | | | The `line_numbers` setting is a string but case shouldn't matter, especially for caching, this is handled in branches already but the caching key was overlooked.
* browsercolumn: Refactor linum_text_lentoonn2022-05-271-4/+10
| | | | | | The calculation isn't difficult but the lines were long and there's several branches involved. Giving `len(str())` a name and introducing names for intermediate results should make it easier to comprehend
* browsercolumn: Fix relative line number widthtoonn2022-05-261-2/+10
| | | | | | | | For relative line numbers the width that actually matters is the width for all the displayed line numbers. The width of the largest index of the displayed files doesn't matter. Only the width of the relative indices and the width of the currently highlighted item's index, unless `relative_current_zero` is enabled.
* browsercolumn: Include linum_text_len in keytoonn2022-05-261-1/+1
| | | | | | | | | | | | | | | | | | | The width of an item needs to be recalculated if the width of the line numbers changes. This happens every time we get to another order of magnitude (an additional digit). This is based on [review comments](https://github.com/ranger/ranger/pull/2346#issuecomment-1062257526) from markus-bauer. The solution opted for here is basically their second bullet point. I tried the third bullet point first, replacing `line_numbers` by `linum_text_len` in the key but this requires recalculating `linum_text_len` to be zero when line numbers are disabled, which feels like a somewhat clunky overloading while we have a perfectly usable boolean flag available. Closes #2346 Co-authored-by: markus-bauer <mail.markus.bauer@gmail.com>
* browsercolumn: Remove off-by-one trailing spacetoonn2022-05-261-4/+5
| | | | | | The file size was always followed by a space in case it needed to be separated from other trailing information but this should only happen if anything actually follows it.
* browsercolumn: Accept line_numbers case insensitivelytoonn2022-05-261-3/+6
|
* browsercolumn: Fix off-by-one in line number widthtoonn2022-05-261-1/+1
| | | | | | | The status bar wasn't taken into account when calculating the width of the visible line numbers. This meant the width would change right before a number with an extra digit appeared or one later than when it disappeared.
* Merge branch 'pylint'toonn2022-05-264-6/+17
|\
| * test_py2_compat: Ignore error message positionstoonn2022-05-261-0/+6
| |
| * runner: Initialize variables outside of try-excepttoonn2022-05-261-2/+4
| |
| * accumulator: Make get_list an abstract methodtoonn2022-05-261-2/+4
| | | | | | | | | | | | Implementations need the `self` parameter and PyLint complains when the number of arguments changes. Since it's never used without reimplementation, `@abstractmethod` is appropriate.
| * colorscheme: Make use an abstract methodtoonn2022-05-261-2/+3
|/ | | | | | | | | | | | | The `use` method has always been decorated as being a `@staticmethod`. Many colorschemes use fields to store certain properties, these then need to be accessed using `self`. This isn't possible with a static method so they override it with a regular method. This is fine as far as Python is concerned but PyLint doesn't like the `self` parameters adding an argument to the method. All colorschemes should actually implement the `use` method anyway so making it an `@abstractmethod` seems appropriate and allows us to include the `self` argument.
* Merge remote-tracking branch 'ferdinandyb/ipynb_preview'toonn2022-04-012-1/+10
|\
| * better textual preview for jupyter notebooksBence Ferdinandy2021-12-292-1/+10
| |
* | Merge branch 'SuperNici-drawioPreview'toonn2022-03-184-13/+27
|\ \
| * | doc: Add draw.io dependency to man pagetoonn2022-03-182-0/+8
| | |
| * | README: Add draw.io dependencytoonn2022-03-181-0/+2
| | |
| * | scope: Fix draw.io width and enable by defaulttoonn2022-03-181-4/+4
| | |
| * | scope: Move draw.io preview to handle_imagetoonn2022-03-181-18/+17
| | |
| * | Makefile: Drop README.md from man page requisitestoonn2022-03-182-5/+9
| | | | | | | | | | | | | | | | | | | | | I believe at some point I added the `README.md` to the prerequisites for the man pages so we wouldn't forget to update them whenever the README was touched. This hasn't worked very well and it often makes particularly the rifle man page regenerate when not needed.
| * | doc: Split lines in man pagetoonn2022-03-181-2/+4
| | |
| * | doc: Add openscad dependency to man pagetoonn2022-03-181-0/+4
| | |
| * | doc: Fix manpage for name filter_stack filtertoonn2022-03-182-5/+5
| | | | | | | | | | | | Fixes #2548
| * | fix indentNici2022-02-131-1/+1
| | |
| * | add drawio Image-PreviewNici2022-02-131-1/+6
| | |
* | | Merge branch 'openscad-doc'toonn2022-03-183-7/+17
|\ \ \
| * | | Makefile: Drop README.md from man page requisitestoonn2022-03-182-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I believe at some point I added the `README.md` to the prerequisites for the man pages so we wouldn't forget to update them whenever the README was touched. This hasn't worked very well and it often makes particularly the rifle man page regenerate when not needed.
| * | | doc: Split lines in man pagetoonn2022-03-181-2/+4
| | | |
| * | | doc: Add openscad dependency to man pagetoonn2022-03-181-0/+4
|/ / /
* | | Merge branch 'doc-filterstack'toonn2022-02-272-5/+5
|\ \ \ | |/ / |/| |
| * | doc: Fix manpage for name filter_stack filtertoonn2022-02-272-5/+5
|/ / | | | | | | Fixes #2548
* | Merge branch 'pylint'toonn2022-02-0519-14/+66
|\ \
| * | Actions: Pytests no longer compatible with Python <3.6toonn2022-02-052-3/+3
| | | | | | | | | | | | | | | We need to test f-strings now and it's a bother making that compatible with Python 2.
| * | vcs: Switch from deprecated isSet to is_settoonn2022-02-051-3/+3
| | |
| * | test_py2_compat: Test f-string detectiontoonn2022-02-051-0/+25
| | |
| * | config.pylintrc: Don't consider f-stringstoonn2022-02-051-1/+1
| | |
| * | img_display: Use `in` Pythonismtoonn2022-02-051-1/+1
| | |
| * | loader: Use `in` Pythonismtoonn2022-02-051-1/+1
| | |
| * | file: Use `in` Pythonismtoonn2022-02-051-1/+1
| | |
| * | Trying to ban f-stringstoonn2022-02-051-0/+8
| | |
| * | pylintrc: Disable consider-using-f-stringtoonn2022-02-051-1/+1
| | | | | | | | | | | | | | | These were introduced in 3.6 so they're not an option. Otherwise they'd be a good idea.
| * | Revert "convert_papermode_to_metadata: Drop disappeared Pylint options"toonn2022-02-051-0/+2
| | | | | | | | | | | | This reverts commit 8372a7602d93eb7fc3d18c8ac071ea9cd6349501.
| * | Revert "manpage_completion_test: Drop disappeared Pylint options"toonn2022-02-051-0/+1
| | | | | | | | | | | | This reverts commit abcdb9b6d76cf56be55c037d90b1c299468d006a.
| * | Revert "plugin_ipc: Drop disappeared Pylint options"toonn2022-02-051-0/+1
| | | | | | | | | | | | This reverts commit 8110d6990ae12e4e55d2ceaefabdb63b39238b6c.
| * | Revert "vcs: Drop disappeared Pylint options"toonn2022-02-051-0/+2
| | | | | | | | | | | | This reverts commit 8b462b245399af66bb2b7dd31ed360548804416b.
| * | Revert "rifle: Drop disappeared Pylint options"toonn2022-02-051-1/+3
| | | | | | | | | | | | This reverts commit 742d02c05890c9d2477cad6138853088a28a83e8.
| * | Revert "popen_forked: Drop disappeared Pylint options"toonn2022-02-051-1/+1
| | | | | | | | | | | | This reverts commit 90380564ca41429771441f1e3cb3cc606ca5e101.
| * | Revert "macrodict: Drop disappeared Pylint options"toonn2022-02-051-1/+1
| | | | | | | | | | | | This reverts commit ade69eb05c5791fe02736cf761d3162dd04fb412.
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-23 07:48:16 +0000