From 385642efacc1e6946ee7e8f4415fa345e70388ec Mon Sep 17 00:00:00 2001 From: hut Date: Sun, 28 Mar 2010 17:33:11 +0200 Subject: fsobject.directory: little optimization in sorting 1. no need to call path.basename.lower() since it's cached in path.basename_lower. 2. no need to convert a bool to int for arithmetic operations 3. path.is_directory is faster than an isinstance() check --- ranger/fsobject/directory.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ranger/fsobject/directory.py b/ranger/fsobject/directory.py index 3ef897e0..b0a93893 100644 --- a/ranger/fsobject/directory.py +++ b/ranger/fsobject/directory.py @@ -29,11 +29,11 @@ def sort_by_basename(path): def sort_by_basename_icase(path): """returns case-insensitive path.basename (for sorting)""" - return path.basename.lower() + return path.basename_lower def sort_by_directory(path): """returns 0 if path is a directory, otherwise 1 (for sorting)""" - return 1 - int( isinstance( path, Directory ) ) + return 1 - path.is_directory class NoDirectoryGiven(Exception): pass -- cgit 1.4.1-2-gfad0