From b84444110868a3b4be4dea89a76aa86b883f151f Mon Sep 17 00:00:00 2001 From: guangzhi Date: Tue, 13 Mar 2018 20:32:12 +0800 Subject: Correct some formatting in fix of issue #1108. Remove some trailing whitespaces etc. Another note: regarding iterm2 or some other terminals on mac, it seems to be rather different to launch a new window in mac than in linux. Some search suggests that you need to issue open -a terminal -n to open a new terminal window. So that would probably involve other changes than simply getting a correct cmdflag. --- ranger/ext/rifle.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/ranger/ext/rifle.py b/ranger/ext/rifle.py index f11f6f2c..0fd8046f 100755 --- a/ranger/ext/rifle.py +++ b/ranger/ext/rifle.py @@ -370,23 +370,22 @@ class Rifle(object): # pylint: disable=too-many-instance-attributes elif term.lower() in ['xterm', 'xterm-256color', 'urxvt', 'rxvt', 'rxvt-256color', 'rxvt-unicode', 'lxterminal', - 'konsole', 'lilyterm', + 'konsole', 'lilyterm', 'cool-retro-term']: cmdflag = '-e' elif term.lower() in ['gnome-terminal', ]: cmdflag = '--' # terminals that are found not working with -e or -x: - # consider uncomment the next 2 lines - #elif term.lower() in ['pantheon-terminal', 'terminology']: - #term = 'xterm' - #cmdflag = '-e' + # consider uncomment the next 2 lines + # elif term.lower() in ['pantheon-terminal', 'terminology']: + # term = 'xterm' + # cmdflag = '-e' # 'tilda opens with -c but doesn't go into editor. Not sure. - #elif term.lower() in ['tilda', ]: - #cmdflag = '-c' + # elif term.lower() in ['tilda', ]: + # cmdflag = '-c' # terminals not tested yet: - #elif term.lower() in ['st', 'stterm', 'termite', 'kitty', - #'iterm2']: - #pass + # elif term.lower() in ['st', 'stterm', 'termite', 'kitty']: + # pass else: cmdflag = '-e' -- cgit 1.4.1-2-gfad0