From 6572e37c5f9526ad0f2a41c2f654a3cdf31db112 Mon Sep 17 00:00:00 2001 From: toonn Date: Wed, 11 Nov 2020 21:10:57 +0100 Subject: Shortcut py2 incompatible pytest tests Three of our pytest tests aren't compatible with python 2 by returning early from these testcases and always making them pass, we avoid false negatives in CI results. --- tests/pylint/test_py2_compat.py | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'tests/pylint') diff --git a/tests/pylint/test_py2_compat.py b/tests/pylint/test_py2_compat.py index a5d2e284..08c8de31 100644 --- a/tests/pylint/test_py2_compat.py +++ b/tests/pylint/test_py2_compat.py @@ -5,6 +5,8 @@ import py2_compat import astroid import pylint.testutils +from sys import version_info +PY2 = version_info[0] < 3 class TestPy2CompatibilityChecker(pylint.testutils.CheckerTestCase): CHECKER_CLASS = py2_compat.Py2CompatibilityChecker @@ -42,6 +44,9 @@ class TestPy2CompatibilityChecker(pylint.testutils.CheckerTestCase): self.checker.visit_classdef(from_new) def test_print_without_import(self): + if PY2: + return + print_function_call = astroid.extract_node(""" print("Print function call without importing print_function") """) @@ -73,6 +78,9 @@ class TestPy2CompatibilityChecker(pylint.testutils.CheckerTestCase): self.checker.visit_call(nested_print_function_call) def test_print_late_import(self): + if PY2: + return + early_print_function_call = astroid.extract_node(""" print("Nested print with import in scope") #@ def f(): @@ -91,6 +99,9 @@ class TestPy2CompatibilityChecker(pylint.testutils.CheckerTestCase): self.checker.visit_call(early_print_function_call) def test_implicit_format_spec(self): + if PY2: + return + implicit_format_spec = astroid.extract_node(""" "{}".format("implicit") #@ """) -- cgit 1.4.1-2-gfad0 From 4984fafed9018f80a2af03ecd8862fd449e2a87c Mon Sep 17 00:00:00 2001 From: toonn Date: Wed, 11 Nov 2020 22:46:29 +0100 Subject: Fix test_py2_compat formatting --- tests/pylint/test_py2_compat.py | 1 + 1 file changed, 1 insertion(+) (limited to 'tests/pylint') diff --git a/tests/pylint/test_py2_compat.py b/tests/pylint/test_py2_compat.py index 08c8de31..bd1ace65 100644 --- a/tests/pylint/test_py2_compat.py +++ b/tests/pylint/test_py2_compat.py @@ -8,6 +8,7 @@ import pylint.testutils from sys import version_info PY2 = version_info[0] < 3 + class TestPy2CompatibilityChecker(pylint.testutils.CheckerTestCase): CHECKER_CLASS = py2_compat.Py2CompatibilityChecker -- cgit 1.4.1-2-gfad0