about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2021-11-18 22:28:44 +0000
committerSergei Trofimovich <slyich@gmail.com>2021-11-18 22:29:11 +0000
commita77a57a6a45ed07c60b31f7cbe977f8e68fadbc8 (patch)
treee3065dedad611e3457edec7b8d58c3a1996868d9
parent753d9dbbdb19df28827e8fdbb36455e1cfd3f52d (diff)
downloadprofani-tty-a77a57a6a45ed07c60b31f7cbe977f8e68fadbc8.tar.gz
src/plugins/python_api.c: drop redundant NULL pointer check
gcc-12 detects redundant check against array of arrays as:

    src/plugins/python_api.c: In function ‘python_api_register_command’:
    src/plugins/python_api.c:199:31: error: the comparison will always evaluate as ‘true’ for the address of ‘c_arguments’ will never be NULL [-Werror=address]
      199 |         while (c_arguments[i] != NULL && c_arguments[i][0] != NULL) {
          |                               ^~
    src/plugins/python_api.c:161:15: note: ‘c_arguments’ declared here
      161 |         char* c_arguments[args_len == 0 ? 0 : args_len + 1][2];
          |               ^~~~~~~~~~~
-rw-r--r--src/plugins/python_api.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/python_api.c b/src/plugins/python_api.c
index 8ea54514..2ccd672b 100644
--- a/src/plugins/python_api.c
+++ b/src/plugins/python_api.c
@@ -196,7 +196,7 @@ python_api_register_command(PyObject* self, PyObject* args)
             free(c_synopsis[i++]);
         }
         i = 0;
-        while (c_arguments[i] != NULL && c_arguments[i][0] != NULL) {
+        while (c_arguments[i][0] != NULL) {
             free(c_arguments[i][0]);
             free(c_arguments[i][1]);
             i++;