From 89d8fc846e17001551c7830524229820665e3abe Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Tue, 9 Jul 2019 09:47:35 +0200 Subject: Fix double free in room id handler Free is done in destructor now. Regards https://github.com/profanity-im/profanity/issues/1148 --- src/xmpp/iq.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/xmpp/iq.c b/src/xmpp/iq.c index 23048b8d..6e89307f 100644 --- a/src/xmpp/iq.c +++ b/src/xmpp/iq.c @@ -2069,8 +2069,6 @@ _room_info_response_id_handler(xmpp_stanza_t *const stanza, void *const userdata mucwin_room_info_error(mucwin, error_message); free(error_message); } - free(cb_data->room); - free(cb_data); return 0; } @@ -2136,9 +2134,6 @@ _room_info_response_id_handler(xmpp_stanza_t *const stanza, void *const userdata g_slist_free_full(identities, (GDestroyNotify)_identity_destroy); } - free(cb_data->room); - free(cb_data); - return 0; } @@ -2448,8 +2443,8 @@ iq_send_stanza(xmpp_stanza_t *const stanza) xmpp_send_raw_string(conn, "%s", text); } xmpp_free(connection_get_ctx(), text); - } + static void _iq_free_room_data(ProfRoomInfoData *roominfo) { -- cgit 1.4.1-2-gfad0