From d3828cf24e0c867c62c84ee2a69d8c132776368a Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Fri, 19 Jul 2019 12:38:33 +0200 Subject: Fix segfault in block command Another case of double free() due to new destructor. Fixes https://github.com/profanity-im/profanity/issues/1156 --- src/xmpp/blocking.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/xmpp/blocking.c b/src/xmpp/blocking.c index d3c84f0d..5784122e 100644 --- a/src/xmpp/blocking.c +++ b/src/xmpp/blocking.c @@ -235,18 +235,15 @@ _block_add_result_handler(xmpp_stanza_t *const stanza, void *const userdata) const char *type = xmpp_stanza_get_type(stanza); if (!type) { log_info("Block response received for %s with no type attribute.", jid); - free(jid); return 0; } if (g_strcmp0(type, "result") != 0) { log_info("Block response received for %s with unrecognised type attribute.", jid); - free(jid); return 0; } cons_show("User %s successfully blocked.", jid); - free(jid); return 0; } @@ -259,18 +256,15 @@ _block_remove_result_handler(xmpp_stanza_t *const stanza, void *const userdata) const char *type = xmpp_stanza_get_type(stanza); if (!type) { log_info("Unblock response received for %s with no type attribute.", jid); - free(jid); return 0; } if (g_strcmp0(type, "result") != 0) { log_info("Unblock response received for %s with unrecognised type attribute.", jid); - free(jid); return 0; } cons_show("User %s successfully unblocked.", jid); - free(jid); return 0; } -- cgit 1.4.1-2-gfad0