From 16174727f48daae6d244835452139e0a1b1cb389 Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Mon, 22 Jul 2019 13:47:52 +0200 Subject: Guard against arg being NULL in cmd_funcs This should actually never happen because we have the mechanism that checks the commands. But let's do it in case we break something in that mechanism and to make clang happy. Fixes clangs: 'Argument with 'nonnull' attribute passed null' --- src/command/cmd_funcs.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'src/command') diff --git a/src/command/cmd_funcs.c b/src/command/cmd_funcs.c index a6c0011f..0099ab67 100644 --- a/src/command/cmd_funcs.c +++ b/src/command/cmd_funcs.c @@ -5406,6 +5406,10 @@ cmd_time(ProfWin *window, const char *const command, gchar **args) gboolean cmd_states(ProfWin *window, const char *const command, gchar **args) { + if (args[0] == NULL) { + return FALSE; + } + _cmd_set_boolean_preference(args[0], command, "Sending chat states", PREF_STATES); // if disabled, disable outtype and gone @@ -5439,6 +5443,10 @@ cmd_wintitle(ProfWin *window, const char *const command, gchar **args) gboolean cmd_outtype(ProfWin *window, const char *const command, gchar **args) { + if (args[0] == NULL) { + return FALSE; + } + _cmd_set_boolean_preference(args[0], command, "Sending typing notifications", PREF_OUTTYPE); // if enabled, enable states @@ -6612,6 +6620,10 @@ cmd_autoconnect(ProfWin *window, const char *const command, gchar **args) gboolean cmd_chlog(ProfWin *window, const char *const command, gchar **args) { + if (args[0] == NULL) { + return FALSE; + } + _cmd_set_boolean_preference(args[0], command, "Chat logging", PREF_CHLOG); // if set to off, disable history @@ -6633,6 +6645,10 @@ cmd_grlog(ProfWin *window, const char *const command, gchar **args) gboolean cmd_history(ProfWin *window, const char *const command, gchar **args) { + if (args[0] == NULL) { + return FALSE; + } + _cmd_set_boolean_preference(args[0], command, "Chat history", PREF_HISTORY); // if set to on, set chlog @@ -6646,6 +6662,10 @@ cmd_history(ProfWin *window, const char *const command, gchar **args) gboolean cmd_carbons(ProfWin *window, const char *const command, gchar **args) { + if (args[0] == NULL) { + return FALSE; + } + _cmd_set_boolean_preference(args[0], command, "Message carbons preference", PREF_CARBONS); jabber_conn_status_t conn_status = connection_get_status(); -- cgit 1.4.1-2-gfad0 py?id=9fb987c29b60414588226eac24d307bfe8b7a938'>ui.py
blob: a0aa800fa947ce9165d704c39cae4b99218c26b2 (plain) (blame) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359