From c8b2979dcda8cca3052164ae9bfd09adbf7523fc Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Mon, 4 Jul 2022 16:45:18 +0200 Subject: Exit *_incoming_msg functions when plain message is empty Fix https://github.com/profanity-im/profanity/issues/1733 --- src/ui/chatwin.c | 6 ++++++ src/ui/mucwin.c | 5 +++++ src/ui/privwin.c | 6 ++++++ 3 files changed, 17 insertions(+) (limited to 'src/ui') diff --git a/src/ui/chatwin.c b/src/ui/chatwin.c index c7cf8ddb..32fd3553 100644 --- a/src/ui/chatwin.c +++ b/src/ui/chatwin.c @@ -310,6 +310,12 @@ void chatwin_incoming_msg(ProfChatWin* chatwin, ProfMessage* message, gboolean win_created) { assert(chatwin != NULL); + + if (message->plain == NULL) { + log_error("chatwin_incoming_msg: Message with no plain field from: %s", message->from_jid); + return; + } + char* old_plain = message->plain; message->plain = plugins_pre_chat_message_display(message->from_jid->barejid, message->from_jid->resourcepart, message->plain); diff --git a/src/ui/mucwin.c b/src/ui/mucwin.c index b48a4a54..3c4d7447 100644 --- a/src/ui/mucwin.c +++ b/src/ui/mucwin.c @@ -551,6 +551,11 @@ mucwin_incoming_msg(ProfMucWin* mucwin, const ProfMessage* const message, GSList assert(mucwin != NULL); int flags = 0; + if (message->plain == NULL) { + log_error("mucwin_incoming_msg: Message with no plain field from: %s", message->from_jid); + return; + } + if (filter_reflection && message_is_sent_by_us(message, TRUE)) { /* Ignore reflection messages */ return; diff --git a/src/ui/privwin.c b/src/ui/privwin.c index 20611ea4..b683a839 100644 --- a/src/ui/privwin.c +++ b/src/ui/privwin.c @@ -39,6 +39,7 @@ #include #include +#include "log.h" #include "config/preferences.h" #include "ui/win_types.h" #include "ui/window.h" @@ -50,6 +51,11 @@ privwin_incoming_msg(ProfPrivateWin* privatewin, ProfMessage* message) { assert(privatewin != NULL); + if (message->plain == NULL) { + log_error("privwin_incoming_msg: Message with no plain field from: %s", message->from_jid); + return; + } + ProfWin* window = (ProfWin*)privatewin; int num = wins_get_num(window); -- cgit 1.4.1-2-gfad0 path: root/svc/post_test.go
blob: 6f68a6688dd26bc2210f9eff28a26998c143580e (plain) (tree) 
f13255f ^



















538e305 ^

a6c8162 ^


6f93835 ^

a6c8162 ^





6f93835 ^

538e305 ^

a6c8162 ^










7db28dd ^

538e305 ^

a6c8162 ^
























6f93835 ^

37142b5 ^

a6c8162 ^







6f93835 ^

a6c8162 ^





a6c8162 ^

6f93835 ^

a6c8162 ^













b957093 ^



37142b5 ^

b957093 ^


538e305 ^

b957093 ^









37142b5 ^

b957093 ^



1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19

20

21
22

23

24
25
26
27
28

29

30

31
32
33
34
35
36
37
38
39
40

41

42

43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66

67

68

69
70
71
72
73
74
75

76

77
78
79
80
81

82

83

84
85
86
87
88
89
90
91
92
93
94
95
96

97
98
99

100

101
102

103

104
105
106
107
108
109
110
111
112

113

114
115
116