From 2e43b0ae62478bede34f6f52f73d22d671425f85 Mon Sep 17 00:00:00 2001
From: John Hernandez <129467592+H3rnand3zzz@users.noreply.github.com>
Date: Mon, 10 Apr 2023 16:21:23 +0200
Subject: Fix releases of os and os_txt stanzas

If custom client is not set and include_os is true,
stanzas might be released without initializiting.

This commit fixes it by introducing an additional check
on usage of custom client.

Related to commit e52ca2fbaa02acec3b2b757369ef5740e7a103da
---
 src/xmpp/iq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'src/xmpp')

diff --git a/src/xmpp/iq.c b/src/xmpp/iq.c
index e48d187a..1faa5b7f 100644
--- a/src/xmpp/iq.c
+++ b/src/xmpp/iq.c
@@ -1697,8 +1697,7 @@ _version_get_handler(xmpp_stanza_t* const stanza)
             xmpp_stanza_add_child(os, os_txt);
             xmpp_stanza_add_child(query, os);
         }
-    }
-    if (is_custom_client && custom_version_str != NULL) {
+    } else if (custom_version_str != NULL) {
         xmpp_stanza_set_text(version_txt, custom_version_str);
         xmpp_stanza_add_child(version, version_txt);
         xmpp_stanza_add_child(query, version);
@@ -1711,7 +1710,7 @@ _version_get_handler(xmpp_stanza_t* const stanza)
     g_string_free(version_str, TRUE);
     xmpp_stanza_release(version_txt);
     xmpp_stanza_release(name_txt);
-    if (include_os) {
+    if (!is_custom_client && include_os) {
         xmpp_stanza_release(os_txt);
         xmpp_stanza_release(os);
     }
-- 
cgit 1.4.1-2-gfad0