about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorAnselm R. Garbe <arg@suckless.org>2007-05-10 13:47:44 +0200
committerAnselm R. Garbe <arg@suckless.org>2007-05-10 13:47:44 +0200
commitb8bccb4ac5222a01ecd6a5f82997ea2ee3b84b8b (patch)
tree83c2aa1803f9a9948c2c8fd9b96bc3da91e57809
parentb6b2f584ecc0510acdf7e1df46ad397cff168335 (diff)
downloaddwm-b8bccb4ac5222a01ecd6a5f82997ea2ee3b84b8b.tar.gz
fixed a potential security flaw
-rw-r--r--client.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/client.c b/client.c
index 03d158f..64da343 100644
--- a/client.c
+++ b/client.c
@@ -365,16 +365,18 @@ updatetitle(Client *c) {
 		XGetWMName(dpy, c->win, &name);
 	if(!name.nitems)
 		return;
-	if(name.encoding == XA_STRING)
-		strncpy(c->name, (char *)name.value, sizeof c->name);
+	if(name.encoding == XA_STRING) {
+		strncpy(c->name, (char *)name.value, sizeof c->name - 1);
+	}
 	else {
 		if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success
 		&& n > 0 && *list)
 		{
-			strncpy(c->name, *list, sizeof c->name);
+			strncpy(c->name, *list, sizeof c->name - 1);
 			XFreeStringList(list);
 		}
 	}
+	c->name[sizeof c->name - 1] = '\0';
 	XFree(name.value);
 }
 
n' href='/akkartik/mu/blame/subx/apps/factorial.subx?h=hlt&id=7e84fc518f4c7d3eb47ae5ab20f2290904be0391'>^
3f8597bc ^
6ff9ce26 ^
a49bc413 ^
ee9a9237 ^


6ff9ce26 ^

ee9a9237 ^
6030d7e2 ^
9d27e966 ^

dd9ba09a ^
6030d7e2 ^
9d27e966 ^
ee9a9237 ^
6030d7e2 ^
dd9ba09a ^
ee9a9237 ^
71ee78f2 ^
ee9a9237 ^
6030d7e2 ^
9d27e966 ^
6030d7e2 ^

9d27e966 ^
6030d7e2 ^


9d27e966 ^
03d50cc8 ^
ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
04be5eb2 ^
9d27e966 ^
6030d7e2 ^
5a9795bb ^
6030d7e2 ^
6ff9ce26 ^
9d27e966 ^
ee9a9237 ^
6030d7e2 ^


9d27e966 ^
6030d7e2 ^
9d27e966 ^
dd9ba09a ^
6030d7e2 ^

dd9ba09a ^
6030d7e2 ^

ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^

dd9ba09a ^
6030d7e2 ^
04be5eb2 ^
ee9a9237 ^
6030d7e2 ^



6ff9ce26 ^
03d50cc8 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^
00439520 ^
ee9a9237 ^
6030d7e2 ^


ee9a9237 ^
6030d7e2 ^
ee9a9237 ^
6030d7e2 ^


d48cfd0f ^
ee9a9237 ^
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107