summary refs log tree commit diff stats
diff options
context:
space:
mode:
authormetagn <metagngn@gmail.com>2023-03-28 11:34:30 +0300
committerGitHub <noreply@github.com>2023-03-28 16:34:30 +0800
commit0630c649c6b4fca4abfa157c5bc6f9f9e50e9c65 (patch)
tree66bd249a599de6ac4997d79e7c85c20e4af6cb9e
parentff5ed1dbb11ff44217ecd8353dc94a6929fadbd0 (diff)
downloadNim-0630c649c6b4fca4abfa157c5bc6f9f9e50e9c65.tar.gz
disable google request in thttpclient (#21572)
was breaking macos CI
-rw-r--r--tests/stdlib/thttpclient.nim10
1 files changed, 6 insertions, 4 deletions
diff --git a/tests/stdlib/thttpclient.nim b/tests/stdlib/thttpclient.nim
index c731c81b0..00e728fa2 100644
--- a/tests/stdlib/thttpclient.nim
+++ b/tests/stdlib/thttpclient.nim
@@ -57,8 +57,9 @@ proc asyncTest() {.async.} =
   doAssert(resp.code == Http404)
   doAssert(resp.status == $Http404)
 
-  resp = await client.request("https://google.com/")
-  doAssert(resp.code.is2xx or resp.code.is3xx)
+  when false: # occasionally does not give success code 
+    resp = await client.request("https://google.com/")
+    doAssert(resp.code.is2xx or resp.code.is3xx)
 
   # getContent
   try:
@@ -118,8 +119,9 @@ proc syncTest() =
   doAssert(resp.code == Http404)
   doAssert(resp.status == $Http404)
 
-  resp = client.request("https://google.com/")
-  doAssert(resp.code.is2xx or resp.code.is3xx)
+  when false: # occasionally does not give success code
+    resp = client.request("https://google.com/")
+    doAssert(resp.code.is2xx or resp.code.is3xx)
 
   # getContent
   try: