diff options
| author | Bung <crc32@qq.com> | 2022-09-22 09:11:39 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-21 21:11:39 -0400 |
| commit | 2afce84616e1de176c9e76a3e0146fff7ab1de10 (patch) | |
| tree | 88b23bb12ca6603a7e7679b487983f0ec5a9b536 | |
| parent | de089d7fdb48a25069c3716ba00774b60c3da370 (diff) | |
| download | Nim-2afce84616e1de176c9e76a3e0146fff7ab1de10.tar.gz | |
Improve error message when instantiating generics with object constructor (#20358)
* Improve error message when instantiating generics with object constructor * follow suggestion * Update compiler/semobjconstr.nim Co-authored-by: Clay Sweetser <Varriount@users.noreply.github.com> * Update tests/errmsgs/t19882_2.nim Co-authored-by: Clay Sweetser <Varriount@users.noreply.github.com>
| -rw-r--r-- | compiler/semobjconstr.nim | 8 | ||||
| -rw-r--r-- | tests/errmsgs/t19882_2.nim | 5 |
2 files changed, 11 insertions, 2 deletions
diff --git a/compiler/semobjconstr.nim b/compiler/semobjconstr.nim index f3efc1719..77bd6b975 100644 --- a/compiler/semobjconstr.nim +++ b/compiler/semobjconstr.nim @@ -398,8 +398,12 @@ proc semObjConstr(c: PContext, n: PNode, flags: TExprFlags; expectedType: PType # multiple times as long as they don't have closures. result.typ.flags.incl tfHasOwned if t.kind != tyObject: - return localErrorNode(c, result, - "object constructor needs an object type".dup(addDeclaredLoc(c.config, t))) + return localErrorNode(c, result, if t.kind != tyGenericBody: + "object constructor needs an object type".dup(addDeclaredLoc(c.config, t)) + else: "cannot instantiate: '" & + typeToString(t, preferDesc) & + "'; the object's generic parameters cannot be inferred and must be explicitly given" + ) # Check if the object is fully initialized by recursively testing each # field (if this is a case object, initialized fields in two different diff --git a/tests/errmsgs/t19882_2.nim b/tests/errmsgs/t19882_2.nim new file mode 100644 index 000000000..7f3055a5d --- /dev/null +++ b/tests/errmsgs/t19882_2.nim @@ -0,0 +1,5 @@ +discard """ + errormsg: "cannot instantiate: 'A[T]'; the object's generic parameters cannot be inferred and must be explicitly given" +""" +type A[T] = object +var a = A() \ No newline at end of file |