summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorAndreas Rumpf <rumpf_a@web.de>2019-03-06 10:15:27 +0100
committerAndreas Rumpf <rumpf_a@web.de>2019-03-06 10:15:27 +0100
commit32c9ca605e407bdcb288c66a3ed23625bf2474be (patch)
tree11db462f115de935bc68ddfae814ddd074fbe7fd
parente3e4cd9fd5fd72264676b8a1d1297751be85d7cf (diff)
downloadNim-32c9ca605e407bdcb288c66a3ed23625bf2474be.tar.gz
fixes #10795
-rw-r--r--lib/pure/asyncdispatch.nim10
-rw-r--r--tests/threads/t8535.nim23
2 files changed, 23 insertions, 10 deletions
diff --git a/lib/pure/asyncdispatch.nim b/lib/pure/asyncdispatch.nim
index 5953ed975..08fa60dbc 100644
--- a/lib/pure/asyncdispatch.nim
+++ b/lib/pure/asyncdispatch.nim
@@ -167,7 +167,7 @@ export asyncstreams
 type
   PDispatcherBase = ref object of RootRef
     timers*: HeapQueue[tuple[finishAt: float, fut: Future[void]]]
-    callbacks*: Deque[proc ()]
+    callbacks*: Deque[proc () {.gcsafe.}]
 
 proc processTimers(
   p: PDispatcherBase, didSomeWork: var bool
@@ -200,7 +200,9 @@ proc adjustTimeout(pollTimeout: int, nextTimer: Option[int]): int {.inline.} =
   if pollTimeout == -1: return
   result = min(pollTimeout, result)
 
-proc callSoon*(cbproc: proc ()) {.gcsafe.}
+proc callSoon*(cbproc: proc () {.gcsafe.}) {.gcsafe.}
+  ## Schedule `cbproc` to be called as soon as possible.
+  ## The callback is called when control returns to the event loop.
 
 proc initCallSoonProc =
   if asyncfutures.getCallSoonProc().isNil:
@@ -1806,9 +1808,7 @@ proc readAll*(future: FutureStream[string]): Future[string] {.async.} =
     else:
       break
 
-proc callSoon*(cbproc: proc ()) =
-  ## Schedule `cbproc` to be called as soon as possible.
-  ## The callback is called when control returns to the event loop.
+proc callSoon(cbproc: proc () {.gcsafe.}) =
   getGlobalDispatcher().callbacks.addLast(cbproc)
 
 proc runForever*() =
diff --git a/tests/threads/t8535.nim b/tests/threads/t8535.nim
index e1b5a1369..dfc95547d 100644
--- a/tests/threads/t8535.nim
+++ b/tests/threads/t8535.nim
@@ -1,16 +1,29 @@
 discard """
-  output: "0"
+  output: '''0
+hello'''
 """
 
 type
-  CircAlloc* [Size: static[int] , T]  =  tuple
-    baseArray           : array[Size,T]
-    index               : uint16
+  CircAlloc*[Size: static[int], T] = tuple
+    baseArray: array[Size,T]
+    index: uint16
 
 type
   Job = object of RootObj
 
-var foo {.threadvar.}: CircAlloc[1,Job]
+var foo {.threadvar.}: CircAlloc[1, Job]
 
 when true:
   echo foo.index
+
+
+# bug #10795
+import asyncdispatch
+import threadpool
+
+proc f1() =
+  waitFor sleepAsync(100)
+  echo "hello"
+
+spawn f1()
+sync()