summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorringabout <43030857+ringabout@users.noreply.github.com>2023-04-26 14:04:13 +0800
committerGitHub <noreply@github.com>2023-04-26 08:04:13 +0200
commit69c193e5e2dbdbadbf2d8767602b27451afd1e5e (patch)
tree3caff591b0455feccea6bf47d0e3b79e6858f80e
parent0032322ea8e4f93f9fc6b7879b5e4bbb5f56c078 (diff)
downloadNim-69c193e5e2dbdbadbf2d8767602b27451afd1e5e.tar.gz
fixes #21731; fixes #21537; disable `warnBareExcept` by default [backport] (#21728)
* disable warnBareExcept for default

* fixes a typo
-rw-r--r--changelogs/changelog_2_0_0.md2
-rw-r--r--compiler/lineinfos.nim2
2 files changed, 2 insertions, 2 deletions
diff --git a/changelogs/changelog_2_0_0.md b/changelogs/changelog_2_0_0.md
index bb0a9bf4d..17f0fcfc4 100644
--- a/changelogs/changelog_2_0_0.md
+++ b/changelogs/changelog_2_0_0.md
@@ -131,7 +131,7 @@
   `foo` had type `proc ()` were assumed by the compiler to mean `foo(a, b, proc () = ...)`.
   This behavior is now deprecated. Use `foo(a, b) do (): ...` or `foo(a, b, proc () = ...)` instead.
 
-- If no exception or any exception deriving from Exception but not Defect or CatchableError given in except, a `warnBareExcept` warning will be triggered.
+- When `--warning[BareExcept]:on` is enabled, if no exception or any exception deriving from Exception but not Defect or CatchableError given in except, a `warnBareExcept` warning will be triggered.
 
 - The experimental strictFuncs feature now disallows a store to the heap via a `ref` or `ptr` indirection.
 
diff --git a/compiler/lineinfos.nim b/compiler/lineinfos.nim
index 44e9cb716..7a51a4db7 100644
--- a/compiler/lineinfos.nim
+++ b/compiler/lineinfos.nim
@@ -248,7 +248,7 @@ type
   TNoteKinds* = set[TNoteKind]
 
 proc computeNotesVerbosity(): array[0..3, TNoteKinds] =
-  result[3] = {low(TNoteKind)..high(TNoteKind)} - {warnObservableStores, warnResultUsed, warnAnyEnumConv}
+  result[3] = {low(TNoteKind)..high(TNoteKind)} - {warnObservableStores, warnResultUsed, warnAnyEnumConv, warnBareExcept}
   result[2] = result[3] - {hintStackTrace, hintExtendedContext, hintDeclaredLoc, hintProcessingStmt}
   result[1] = result[2] - {warnProveField, warnProveIndex,
     warnGcUnsafe, hintPath, hintDependency, hintCodeBegin, hintCodeEnd,