Fix `newStringUninit` not setting the '\0' terminator [backport] (#22746)

Causes problems when working with `cstring`s.

1 files changed, 6 insertions, 2 deletions

diff --git a/lib/system.nim b/lib/system.nim
index 97d9d72ad..1ded4090b 100644
--- a/lib/system.nim
+++ b/lib/system.nim
@@ -1639,10 +1639,14 @@ when not defined(js):
     ## the same effect can be achieved with the `&` operator or with `add`.
     result = newStringOfCap(len)
     when defined(nimSeqsV2):
-      cast[ptr int](addr result)[] = len
+      let s = cast[ptr NimStringV2](addr result)
+      if len > 0:
+        s.len = len
+        s.p.data[len] = '\0'
     else:
-      var s = cast[PGenericSeq](result)
+      let s = cast[NimString](result)
       s.len = len
+      s.data[len] = '\0'
 else:
   proc newStringUninit*(len: Natural): string {.
     magic: "NewString", importc: "mnewString", noSideEffect.}