diff options
author | Araq <rumpf_a@web.de> | 2018-12-12 17:51:33 +0100 |
---|---|---|
committer | Araq <rumpf_a@web.de> | 2018-12-12 17:51:33 +0100 |
commit | ac8274c60f860b334a08199c4c0a65620962ef2a (patch) | |
tree | 6afc4046622ff10ff383a1e2a412bef325555158 | |
parent | eb8383cb28e52bb9a790a743de442e4b71687001 (diff) | |
parent | 9f453592a40b6db4ab6715fe2f29ca573bb89148 (diff) | |
download | Nim-ac8274c60f860b334a08199c4c0a65620962ef2a.tar.gz |
fix merge conflict
-rw-r--r-- | changelog.md | 4 | ||||
-rw-r--r-- | lib/pure/collections/sequtils.nim | 24 | ||||
-rw-r--r-- | lib/pure/strmisc.nim | 29 |
3 files changed, 51 insertions, 6 deletions
diff --git a/changelog.md b/changelog.md index 97f210792..41be28880 100644 --- a/changelog.md +++ b/changelog.md @@ -86,10 +86,10 @@ proc enumToString*(enums: openArray[enum]): string = - Added `macros.isInstantiationOf` for checking if the proc symbol is instantiation of generic proc symbol. -- There is a new stdlib mdoule `experimental/diff` to compute the famous "diff" +- Added the parameter ``isSorted`` for the ``sequtils.deduplicate`` proc. +- There is a new stdlib module `std/diff` to compute the famous "diff" of two texts by line. - ### Library changes - The string output of `macros.lispRepr` proc has been tweaked diff --git a/lib/pure/collections/sequtils.nim b/lib/pure/collections/sequtils.nim index be10780ff..39ba6df49 100644 --- a/lib/pure/collections/sequtils.nim +++ b/lib/pure/collections/sequtils.nim @@ -115,7 +115,7 @@ proc repeat*[T](x: T, n: Natural): seq[T] = for i in 0 ..< n: result[i] = x -proc deduplicate*[T](s: openArray[T]): seq[T] = +proc deduplicate*[T](s: openArray[T], isSorted: bool = false): seq[T] = ## Returns a new sequence without duplicates. ## ## Example: @@ -129,8 +129,17 @@ proc deduplicate*[T](s: openArray[T]): seq[T] = ## assert unique1 == @[1, 3, 4, 2, 8] ## assert unique2 == @["a", "c", "d"] result = @[] - for itm in items(s): - if not result.contains(itm): result.add(itm) + if s.len > 0: + if isSorted: + var prev = s[0] + result.add(prev) + for i in 1..s.high: + if s[i] != prev: + prev = s[i] + result.add(prev) + else: + for itm in items(s): + if not result.contains(itm): result.add(itm) proc zip*[S, T](s1: openArray[S], s2: openArray[T]): seq[tuple[a: S, b: T]] = ## Returns a new sequence with a combination of the two input containers. @@ -827,6 +836,7 @@ macro mapLiterals*(constructor, op: untyped; when isMainModule: import strutils + from algorithm import sorted # helper for testing double substitution side effects which are handled # by `evalOnceAs` @@ -902,10 +912,18 @@ when isMainModule: unique2 = deduplicate(dup2) unique3 = deduplicate(dup3) unique4 = deduplicate(dup4) + unique5 = deduplicate(dup1.sorted, true) + unique6 = deduplicate(dup2, true) + unique7 = deduplicate(dup3.sorted, true) + unique8 = deduplicate(dup4, true) assert unique1 == @[1, 3, 4, 2, 8] assert unique2 == @["a", "c", "d"] assert unique3 == @[1, 3, 4, 2, 8] assert unique4 == @["a", "c", "d"] + assert unique5 == @[1, 2, 3, 4, 8] + assert unique6 == @["a", "c", "d"] + assert unique7 == @[1, 2, 3, 4, 8] + assert unique8 == @["a", "c", "d"] block: # zip test let diff --git a/lib/pure/strmisc.nim b/lib/pure/strmisc.nim index d1ff920c9..31f1471ff 100644 --- a/lib/pure/strmisc.nim +++ b/lib/pure/strmisc.nim @@ -16,7 +16,20 @@ import strutils proc expandTabs*(s: string, tabSize: int = 8): string {.noSideEffect, procvar.} = - ## Expand tab characters in `s` by `tabSize` spaces + ## Expand tab characters in `s` replacing them by spaces. + ## + ## The amount of inserted spaces for each tab character is the difference + ## between the current column number and the next tab position. Tab positions + ## occur every `tabSize` characters. + ## The column number starts at 0 and is increased with every single character + ## and inserted space, except for newline, which resets the column number + ## back to 0. + runnableExamples: + doAssert expandTabs("\t", 4) == " " + doAssert expandTabs("\tfoo\t", 4) == " foo " + doAssert expandTabs("\tfoo\tbar", 4) == " foo bar" + doAssert expandTabs("\tfoo\tbar\t", 4) == " foo bar " + doAssert expandTabs("ab\tcd\n\txy\t", 3) == "ab cd\n xy " result = newStringOfCap(s.len + s.len shr 2) var pos = 0 @@ -48,6 +61,13 @@ proc partition*(s: string, sep: string, ## Returns a 3 string tuple of (beforeSep, `sep`, afterSep) or ## (`s`, "", "") if `sep` is not found and `right` is false or ## ("", "", `s`) if `sep` is not found and `right` is true + runnableExamples: + doAssert partition("foo:bar", ":") == ("foo", ":", "bar") + doAssert partition("foobarbar", "bar") == ("foo", "bar", "bar") + doAssert partition("foobarbar", "bank") == ("foobarbar", "", "") + doAssert partition("foobarbar", "foo") == ("", "foo", "barbar") + doAssert partition("foofoobar", "bar") == ("foofoo", "bar", "") + let position = if right: s.rfind(sep) else: s.find(sep) if position != -1: return (s[0 ..< position], sep, s[position + sep.len ..< s.len]) @@ -59,6 +79,13 @@ proc rpartition*(s: string, sep: string): (string, string, string) ## ## Returns a 3 string tuple of (beforeSep, `sep`, afterSep) or ## ("", "", `s`) if `sep` is not found + runnableExamples: + doAssert rpartition("foo:bar", ":") == ("foo", ":", "bar") + doAssert rpartition("foobarbar", "bar") == ("foobar", "bar", "") + doAssert rpartition("foobarbar", "bank") == ("", "", "foobarbar") + doAssert rpartition("foobarbar", "foo") == ("", "foo", "barbar") + doAssert rpartition("foofoobar", "bar") == ("foofoo", "bar", "") + return partition(s, sep, right = true) when isMainModule: |