summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMiran <narimiran@disroot.org>2022-04-06 16:18:10 +0200
committerGitHub <noreply@github.com>2022-04-06 16:18:10 +0200
commitc322faaf384bfcde4dd5a6e6eb9355d10c2e9597 (patch)
tree38fbcfedb5e97e4b524701e5b562705f06151308
parent5a995ffc53ac7c1a51ab62440a58af2f4e43963b (diff)
downloadNim-c322faaf384bfcde4dd5a6e6eb9355d10c2e9597.tar.gz
[backport] fix broken SSL tests (#19684)
* [backport] fix broken SSL tests

* remove a flaky one
-rw-r--r--tests/untestable/thttpclient_ssl_remotenetwork.nim11
1 files changed, 5 insertions, 6 deletions
diff --git a/tests/untestable/thttpclient_ssl_remotenetwork.nim b/tests/untestable/thttpclient_ssl_remotenetwork.nim
index d8137e516..cbb86dc13 100644
--- a/tests/untestable/thttpclient_ssl_remotenetwork.nim
+++ b/tests/untestable/thttpclient_ssl_remotenetwork.nim
@@ -32,7 +32,7 @@ when enableRemoteNetworking and (defined(nimTestsEnableFlaky) or not defined(win
       good, bad, dubious, good_broken, bad_broken, dubious_broken
     CertTest = tuple[url:string, category:Category, desc: string]
 
-  const certificate_tests: array[0..55, CertTest] = [
+  const certificate_tests: array[0..54, CertTest] = [
     ("https://wrong.host.badssl.com/", bad, "wrong.host"),
     ("https://captive-portal.badssl.com/", bad, "captive-portal"),
     ("https://expired.badssl.com/", bad, "expired"),
@@ -41,13 +41,12 @@ when enableRemoteNetworking and (defined(nimTestsEnableFlaky) or not defined(win
     ("https://untrusted-root.badssl.com/", bad, "untrusted-root"),
     ("https://revoked.badssl.com/", bad_broken, "revoked"),
     ("https://pinning-test.badssl.com/", bad_broken, "pinning-test"),
-    ("https://no-common-name.badssl.com/", dubious_broken, "no-common-name"),
-    ("https://no-subject.badssl.com/", dubious_broken, "no-subject"),
-    ("https://incomplete-chain.badssl.com/", dubious_broken, "incomplete-chain"),
+    ("https://no-common-name.badssl.com/", bad, "no-common-name"),
+    ("https://no-subject.badssl.com/", bad, "no-subject"),
     ("https://sha1-intermediate.badssl.com/", bad, "sha1-intermediate"),
     ("https://sha256.badssl.com/", good, "sha256"),
-    ("https://sha384.badssl.com/", good, "sha384"),
-    ("https://sha512.badssl.com/", good, "sha512"),
+    ("https://sha384.badssl.com/", bad, "sha384"),
+    ("https://sha512.badssl.com/", bad, "sha512"),
     ("https://1000-sans.badssl.com/", bad, "1000-sans"),
     ("https://10000-sans.badssl.com/", good_broken, "10000-sans"),
     ("https://ecc256.badssl.com/", good, "ecc256"),