summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorringabout <43030857+ringabout@users.noreply.github.com>2023-08-13 06:02:36 +0800
committerGitHub <noreply@github.com>2023-08-13 00:02:36 +0200
commit9207d77848d6f5db3635ae64f3cd4972cdbe3296 (patch)
treecf81cd26d4364933e3443a8bf6a199972cc51019
parent4c892231714fb64942b5014df0424de8fb732b73 (diff)
downloadNim-9207d77848d6f5db3635ae64f3cd4972cdbe3296.tar.gz
fixes bareExcept warnings; catch specific exceptions (#21119)
* fixes bareExcept warnings; catch specific exceptions

* Update lib/pure/coro.nim
-rw-r--r--lib/pure/asynchttpserver.nim2
-rw-r--r--lib/std/private/osdirs.nim2
-rw-r--r--lib/std/private/osfiles.nim4
3 files changed, 4 insertions, 4 deletions
diff --git a/lib/pure/asynchttpserver.nim b/lib/pure/asynchttpserver.nim
index 9b369c4bc..0638d21aa 100644
--- a/lib/pure/asynchttpserver.nim
+++ b/lib/pure/asynchttpserver.nim
@@ -381,7 +381,7 @@ const
 proc listen*(server: AsyncHttpServer; port: Port; address = ""; domain = AF_INET) =
   ## Listen to the given port and address.
   when declared(maxDescriptors):
-    server.maxFDs = try: maxDescriptors() except: nimMaxDescriptorsFallback
+    server.maxFDs = try: maxDescriptors() except OSError: nimMaxDescriptorsFallback
   else:
     server.maxFDs = nimMaxDescriptorsFallback
   server.socket = newAsyncSocket(domain)
diff --git a/lib/std/private/osdirs.nim b/lib/std/private/osdirs.nim
index a4318367d..e204b25e4 100644
--- a/lib/std/private/osdirs.nim
+++ b/lib/std/private/osdirs.nim
@@ -515,7 +515,7 @@ proc copyDirWithPermissions*(source, dest: string,
     try:
       setFilePermissions(dest, getFilePermissions(source), followSymlinks =
                          false)
-    except:
+    except OSError:
       if not ignorePermissionErrors:
         raise
   for kind, path in walkDir(source):
diff --git a/lib/std/private/osfiles.nim b/lib/std/private/osfiles.nim
index f2e7bf11d..69a5af138 100644
--- a/lib/std/private/osfiles.nim
+++ b/lib/std/private/osfiles.nim
@@ -311,7 +311,7 @@ proc copyFileWithPermissions*(source, dest: string,
     try:
       setFilePermissions(dest, getFilePermissions(source), followSymlinks =
                          (cfSymlinkFollow in options))
-    except:
+    except OSError:
       if not ignorePermissionErrors:
         raise
 
@@ -402,6 +402,6 @@ proc moveFile*(source, dest: string) {.rtl, extern: "nos$1",
       copyFile(source, dest, {cfSymlinkAsIs})
       try:
         removeFile(source)
-      except:
+      except OSError:
         discard tryRemoveFile(dest)
         raise