summary refs log tree commit diff stats
path: root/compiler
diff options
context:
space:
mode:
authorringabout <43030857+ringabout@users.noreply.github.com>2024-04-13 22:30:57 +0800
committerGitHub <noreply@github.com>2024-04-13 16:30:57 +0200
commit5d2a712b0eb9caefac0a008c7b9551ddeeab9e0f (patch)
treee7bd7b86e7b648748311616b23b7d8988ea01d80 /compiler
parent1bd095521856d4d1f9fb1b6ba580df3c815196f6 (diff)
downloadNim-5d2a712b0eb9caefac0a008c7b9551ddeeab9e0f.tar.gz
[JS backend] improve `discard` statement; ridding of the awkward special variable `_` (#23498)
According to
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/Expression_statement,
some expression statements need parentheses to make it unambiguous. `_`
introduced in the https://github.com/nim-lang/Nim/pull/15789 is
unnecessary. We can get rid of it by adding parentheses so that object
literals are not ambiguous with block statements.
Diffstat (limited to 'compiler')
-rw-r--r--compiler/jsgen.nim2
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/jsgen.nim b/compiler/jsgen.nim
index 1d4f5519a..15c5cd030 100644
--- a/compiler/jsgen.nim
+++ b/compiler/jsgen.nim
@@ -2985,7 +2985,7 @@ proc gen(p: PProc, n: PNode, r: var TCompRes) =
     if n[0].kind != nkEmpty:
       genLineDir(p, n)
       gen(p, n[0], r)
-      r.res = "var _ = " & r.res
+      r.res = "(" & r.res & ")"
   of nkAsmStmt:
     warningDeprecated(p.config, n.info, "'asm' for the JS target is deprecated, use the 'emit' pragma")
     genAsmOrEmitStmt(p, n, true)