diff options
| author | metagn <metagngn@gmail.com> | 2024-05-10 11:30:57 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-10 10:30:57 +0200 |
| commit | c101490a0c3422cde5a6d2fd686e5ff5feb7237f (patch) | |
| tree | ddad3cbe0c3ff72cf34c1099d247d5cb377e1775 /compiler | |
| parent | 1eb9aac2f7a8469a682528a0d63128d599fabae7 (diff) | |
| download | Nim-c101490a0c3422cde5a6d2fd686e5ff5feb7237f.tar.gz | |
remove bad type inference behavior for enum identifiers (#23588)
refs https://github.com/nim-lang/Nim/issues/23586#issuecomment-2102113750 In #20091 a bad kind of type inference was mistakenly left in where if an identifier `abc` had an expected type of an enum type `Enum`, and `Enum` had a member called `abc`, the identifier would change to be that enum member. This causes bugs where a local symbol can have the same name as an enum member but have a different value. I had assumed this behavior was removed since but it wasn't, and CI seems to pass having it removed. A separate PR needs to be made for the 2.0 branch because these lines were moved around during a refactoring in #23123 which is not in 2.0.
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/semexprs.nim | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/compiler/semexprs.nim b/compiler/semexprs.nim index 92757c77a..6893f7287 100644 --- a/compiler/semexprs.nim +++ b/compiler/semexprs.nim @@ -3028,13 +3028,6 @@ proc resolveIdentToSym(c: PContext, n: PNode, resultNode: var PNode, flags: TExprFlags, expectedType: PType): PSym = # result is nil on error or if a node that can't produce a sym is resolved let ident = considerQuotedIdent(c, n) - if expectedType != nil and ( - let expected = expectedType.skipTypes(abstractRange-{tyDistinct}); - expected.kind == tyEnum): - let nameId = ident.id - for f in expected.n: - if f.kind == nkSym and f.sym.name.id == nameId: - return f.sym var filter = {low(TSymKind)..high(TSymKind)} if efNoEvaluateGeneric in flags: # `a[...]` where `a` is a module or package is not possible |