summary refs log tree commit diff stats
path: root/lib/std/enumutils.nim
diff options
context:
space:
mode:
authorquantimnot <54247259+quantimnot@users.noreply.github.com>2021-07-15 14:43:57 -0400
committerGitHub <noreply@github.com>2021-07-15 20:43:57 +0200
commita9701f6531288ab3ba2c2a7ff0124802ae78122c (patch)
tree63eafc6ea0941afb9f6b1c10e5825f981eb9a594 /lib/std/enumutils.nim
parentaf3d2d8ad90c31161c34f0d4f82cd0ac4a9b3d00 (diff)
downloadNim-a9701f6531288ab3ba2c2a7ff0124802ae78122c.tar.gz
Extended side effect error messages (#18418)
* Extended side effect error messages

* Applied feedback:
- refactored `markSideEffect`
- refactored string interpolations
- single message
- skip diagnostics in `system.compiles` context

Other:
- started a test of diagnostic messages

[ci skip] Tests aren't updated yet because messaging isn't nailed down.

* - Added hints of where for side effect call locations.
- Tried to clarify the reasons.

* fix tests

* Applied PR review feedback:
  - moved collection of side effects from TSym to TContext
  - used pragma shorthand form `.sideEffect` and `.noSideEffect` in messages
  - added leading '>' to structured messages for readability
  - changed `sempass2.markSideEffect` to a proc
  - replaced `system.echo` in the test to make the test compatible with Windows

* Applied NEP1 formatting suggestion

Co-authored-by: quantimnot <quantimnot@users.noreply.github.com>
Diffstat (limited to 'lib/std/enumutils.nim')
0 files changed, 0 insertions, 0 deletions