summary refs log tree commit diff stats
path: root/lib/system/countbits_impl.nim
diff options
context:
space:
mode:
authorTimothee Cour <timothee.cour2@gmail.com>2022-04-07 14:38:01 -0700
committerGitHub <noreply@github.com>2022-04-07 17:38:01 -0400
commite78ef57c93d66da483e0482ce0907dfe16dc8d27 (patch)
tree32ba3900b479bc2e046aca563df99c1be77a5d9d /lib/system/countbits_impl.nim
parent1807de38e52f45c2fb88dac9b99b47729b12ebae (diff)
downloadNim-e78ef57c93d66da483e0482ce0907dfe16dc8d27.tar.gz
typetraits: add toSigned, toUnsigned (#18445)
* typetraits: add toSigned, toUnsigned

* improve and add tests

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Co-authored-by: flywind <xzsflywind@gmail.com>
Diffstat (limited to 'lib/system/countbits_impl.nim')
-rw-r--r--lib/system/countbits_impl.nim6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/system/countbits_impl.nim b/lib/system/countbits_impl.nim
index 020423e01..34969cb32 100644
--- a/lib/system/countbits_impl.nim
+++ b/lib/system/countbits_impl.nim
@@ -9,8 +9,7 @@
 
 ## Contains the used algorithms for counting bits.
 
-from std/private/bitops_utils import forwardImpl, toUnsigned
-
+from std/private/bitops_utils import forwardImpl, castToUnsigned
 
 const useBuiltins* = not defined(noIntrinsicsBitOpts)
 const noUndefined* = defined(noUndefinedBitOpts)
@@ -65,8 +64,7 @@ func countSetBitsImpl*(x: SomeInteger): int {.inline.} =
   ## Counts the set bits in an integer (also called `Hamming weight`:idx:).
   # TODO: figure out if ICC support _popcnt32/_popcnt64 on platform without POPCNT.
   # like GCC and MSVC
-  when x is SomeSignedInt:
-    let x = x.toUnsigned
+  let x = x.castToUnsigned
   when nimvm:
     result = forwardImpl(countBitsImpl, x)
   else: