summary refs log tree commit diff stats
path: root/lib/system
diff options
context:
space:
mode:
authorringabout <43030857+ringabout@users.noreply.github.com>2024-04-19 00:52:30 +0800
committerGitHub <noreply@github.com>2024-04-18 18:52:30 +0200
commit9e1d0d15137c6439d886406293a25eaa16b600c5 (patch)
treeb74463823f235d856e7808d546c3b59b99ad9505 /lib/system
parentd6823f477672e61017e9c1ce3b5221a2b80fc1b7 (diff)
downloadNim-9e1d0d15137c6439d886406293a25eaa16b600c5.tar.gz
fixes #4695; closure iterators support for JS backend (#23493)
fixes #4695

ref https://github.com/nim-lang/Nim/pull/15818

Since `nkState` is only for the main loop state labels and `nkGotoState`
is used only for dispatching the `:state` (since
https://github.com/nim-lang/Nim/pull/7770), it's feasible to rewrite the
loop body into a single case-based dispatcher, which enables support for
JS, VM backend. `nkState` Node is replaced by a label and Node pair and
`nkGotoState` is only used for intermediary processing. Backends only
need to implement `nkBreakState` and `closureIterSetupExc` to support
closure iterators.

pending https://github.com/nim-lang/Nim/pull/23484

<del> I also observed some performance boost for C backend in the
release mode (not in the danger mode though, I suppose the old
implementation is optimized into computed goto in the danger mode)
</del>

allPathsAsgnResult???
Diffstat (limited to 'lib/system')
-rw-r--r--lib/system/jssys.nim4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/system/jssys.nim b/lib/system/jssys.nim
index ffd23b12d..9f9a410d5 100644
--- a/lib/system/jssys.nim
+++ b/lib/system/jssys.nim
@@ -72,6 +72,10 @@ proc getCurrentExceptionMsg*(): string =
 proc setCurrentException*(exc: ref Exception) =
   lastJSError = cast[PJSError](exc)
 
+proc closureIterSetupExc(e: ref Exception) {.compilerproc, inline.} =
+  ## Used to set up exception handling for closure iterators
+  setCurrentException(e)
+
 proc auxWriteStackTrace(f: PCallFrame): string =
   type
     TempFrame = tuple[procname: cstring, line: int, filename: cstring]