summary refs log tree commit diff stats
path: root/lib
diff options
context:
space:
mode:
authorDominik Picheta <dominikpicheta@googlemail.com>2018-01-12 08:59:29 +0000
committerGitHub <noreply@github.com>2018-01-12 08:59:29 +0000
commit471ae7e081425a77921bb6dc8b1da27ac8fd7e63 (patch)
treeea9edd2b7d1df1fd2691c7b2ea9bb4de954bdb3a /lib
parent3647c9c8222f2bfecf88d56403455e56084634f9 (diff)
parentcfc0a58417e4b6967fbb334e8d6556dccc1efad3 (diff)
downloadNim-471ae7e081425a77921bb6dc8b1da27ac8fd7e63.tar.gz
Merge pull request #7067 from yglukhov/httpclient-crash
Fixed crash in ssl httpclient
Diffstat (limited to 'lib')
-rw-r--r--lib/pure/httpclient.nim12
1 files changed, 9 insertions, 3 deletions
diff --git a/lib/pure/httpclient.nim b/lib/pure/httpclient.nim
index 54a8498fa..aefcff37a 100644
--- a/lib/pure/httpclient.nim
+++ b/lib/pure/httpclient.nim
@@ -923,8 +923,14 @@ proc parseChunks(client: HttpClient | AsyncHttpClient): Future[void]
     if chunkSize <= 0:
       discard await recvFull(client, 2, client.timeout, false) # Skip \c\L
       break
-    discard await recvFull(client, chunkSize, client.timeout, true)
-    discard await recvFull(client, 2, client.timeout, false) # Skip \c\L
+    var bytesRead = await recvFull(client, chunkSize, client.timeout, true)
+    if bytesRead != chunkSize:
+      httpError("Server terminated connection prematurely")
+
+    bytesRead = await recvFull(client, 2, client.timeout, false) # Skip \c\L
+    if bytesRead != 2:
+      httpError("Server terminated connection prematurely")
+
     # Trailer headers will only be sent if the request specifies that we want
     # them: http://tools.ietf.org/html/rfc2616#section-3.6.1
 
@@ -965,7 +971,7 @@ proc parseBody(client: HttpClient | AsyncHttpClient,
       if headers.getOrDefault"Connection" == "close" or httpVersion == "1.0":
         while true:
           let recvLen = await client.recvFull(4000, client.timeout, true)
-          if recvLen == 0:
+          if recvLen != 4000:
             client.close()
             break