summary refs log tree commit diff stats
path: root/lib
diff options
context:
space:
mode:
authorc-blake <c-blake@users.noreply.github.com>2024-07-15 12:11:06 +0000
committerGitHub <noreply@github.com>2024-07-15 14:11:06 +0200
commitc11b3f3fc75156c1ce7ad31b631ed4196c3d5ba5 (patch)
treef44b60fa195e82b773cc8cd4c67498b49ef435cb /lib
parenta5186a9d8b3cd236fb3535eb419f88436d264f42 (diff)
downloadNim-c11b3f3fc75156c1ce7ad31b631ed4196c3d5ba5.tar.gz
Silence `hint:performance` message when using very basic http client (#23832)
code such as:
```Nim
import std/httpclient # nim c --hint:performance:on
echo newHttpClient(proxy=nil,
  headers=newHttpHeaders({"Accept": "*/*"})).getContent("x")
```
(Fix was suggested by @ringabout in a private channel.)

Seems useful since `httpclient` is so basic/probably pervasive with many
hundreds of `import`s across the NimbleVerse.
Diffstat (limited to 'lib')
-rw-r--r--lib/pure/httpcore.nim3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/pure/httpcore.nim b/lib/pure/httpcore.nim
index 45365c185..5ccab379c 100644
--- a/lib/pure/httpcore.nim
+++ b/lib/pure/httpcore.nim
@@ -164,7 +164,8 @@ func `[]`*(headers: HttpHeaders, key: string): HttpHeaderValues =
   ## To access multiple values of a key, use the overloaded `[]` below or
   ## to get all of them access the `table` field directly.
   {.cast(noSideEffect).}:
-    return headers.table[headers.toCaseInsensitive(key)].HttpHeaderValues
+    let tmp = headers.table[headers.toCaseInsensitive(key)]
+    return HttpHeaderValues(tmp)
 
 converter toString*(values: HttpHeaderValues): string =
   return seq[string](values)[0]