summary refs log tree commit diff stats
path: root/readme.md
diff options
context:
space:
mode:
authormetagn <metagngn@gmail.com>2024-10-03 20:35:53 +0300
committerGitHub <noreply@github.com>2024-10-03 19:35:53 +0200
commitd98ef312f0cf8745d39c940b16d8d2dce1dfa70f (patch)
treed4e69247521cab04e5a4e07931f02c25dbf232f9 /readme.md
parent89978b48baeed0c745d45d666a9786c8d9457581 (diff)
downloadNim-d98ef312f0cf8745d39c940b16d8d2dce1dfa70f.tar.gz
don't construct array type for already typed `nkBracket` node (#24224)
fixes #23010, split from #24195

When resemming bracket nodes, the compiler currently unconditionally
makes a new node with an array type based on the node. However the VM
can generate bracket nodes with `seq` types, which this erases. To fix
this, if a bracket node already has a type, we still resem the bracket
node, but don't construct a new type for it, instead using the type of
the original node.

A version of this was rejected that didn't resem the node at all if it
was typed, but I can't find it. The difference with this one is that the
individual elements are still resemmed.

This should fix the break caused by #24184 so we could redo it after
this PR but it might still have issues, not to mention the related
pre-existing issues like #22793, #12559 etc.
Diffstat (limited to 'readme.md')
0 files changed, 0 insertions, 0 deletions